Skip to content

Conversation

@DarCampbell
Copy link
Contributor

To aid in completing Use edge for blazorwasm config by default #33088

Changing default browser from chrome to edge

@JoeRobich
Copy link
Member

This appears to be part of dotnet/aspnetcore#33088. cc: @captainsafia

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

Test failure seems to be unrelated:

  1) OmnisharpCompletionProvider: Returns the completion items
       Override completion has additional edits sync:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at /home/runner/work/omnisharp-vscode/omnisharp-vscode/test/integrationTests/completionProvider.integration.test.ts:80:50
      at Generator.next (<anonymous>)
      at fulfilled (out/test/integrationTests/completionProvider.integration.test.js:9:58)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)

Can we rekick that build @JoeRobich?

@JoeRobich JoeRobich merged commit 9e5ad03 into dotnet:master Oct 27, 2021
@JoeRobich
Copy link
Member

@DarCampbell Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants