Skip to content

Support relative paths with omnisharp.testRunSettings #4860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2021
Merged

Support relative paths with omnisharp.testRunSettings #4860

merged 3 commits into from
Nov 1, 2021

Conversation

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Oct 29, 2021

  • Adds omnisharp.testRunSettings to the package.json
  • Will convert relative paths to absolute paths before sending to O#

@JoeRobich
Copy link
Member Author

JoeRobich commented Oct 29, 2021

@vzarytovskii @nohwnd Please take a look

@JoeRobich JoeRobich merged commit 19deb43 into dotnet:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@filipw filipw filipw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeRobich @filipw