Skip to content

Conversation

@caslan
Copy link
Contributor

@caslan caslan commented Jun 29, 2016

package.json Outdated
"name": "csharp",
"publisher": "ms-vscode",
"version": "1.1.7",
"version": "1.1.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go to 1.2.0 since:

  1. This is a breaking change (we are loosing rc2 debugging)
  2. Leaves us space to release more 1.1.x vsix's (ex: to fix OmniSharp)

@chuckries
Copy link
Contributor

@caslan These packages have been pushed to nuget.org, correct?

@caslan
Copy link
Contributor Author

caslan commented Jun 29, 2016

The release will come out of master, which references myget so we should be good. Changing the version to 1.2 is a good idea.

@DustinCampbell
Copy link
Member

Yes, let's flip it to 1.2.

"Microsoft.VisualStudio.OpenDebugAD7": "1.0.20614-preview-2",
"NETStandard.Library": "1.5.0-rc2-24027",
"Microsoft.VisualStudio.clrdbg": "14.0.25429-preview-3095034",
"Microsoft.VisualStudio.clrdbg.MIEngine": "14.0.30628-preview-1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that I accidentally missed Wes's MIEngine commit from yesterday in this build. I kicked off a new build with that. We probably should take that too.

@gregg-miskelly
Copy link
Contributor

We should update README.md with a 'What's new' before we post the .vsix. I will send in a PR real quick.

@DustinCampbell
Copy link
Member

In addition, I hope to have OmniSharp ready today. I'm just finishing up installing the additional distros so I can test.

@caslan
Copy link
Contributor Author

caslan commented Jun 29, 2016

@DustinCampbell, we have Fedora, openSuse, Linux Mint, Oracle Linux distros which we can give you remote access

@caslan caslan force-pushed the updatepackageversions branch from e4e297f to 0de9d6e Compare June 29, 2016 17:27
@caslan
Copy link
Contributor Author

caslan commented Jun 29, 2016

Ok, updated version to 1.2.0, update MIEngine version, removed import definitions from install.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants