-
Notifications
You must be signed in to change notification settings - Fork 728
Update package versions #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
| "name": "csharp", | ||
| "publisher": "ms-vscode", | ||
| "version": "1.1.7", | ||
| "version": "1.1.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should go to 1.2.0 since:
- This is a breaking change (we are loosing rc2 debugging)
- Leaves us space to release more 1.1.x vsix's (ex: to fix OmniSharp)
|
@caslan These packages have been pushed to nuget.org, correct? |
|
The release will come out of master, which references myget so we should be good. Changing the version to 1.2 is a good idea. |
|
Yes, let's flip it to 1.2. |
src/coreclr-debug/install.ts
Outdated
| "Microsoft.VisualStudio.OpenDebugAD7": "1.0.20614-preview-2", | ||
| "NETStandard.Library": "1.5.0-rc2-24027", | ||
| "Microsoft.VisualStudio.clrdbg": "14.0.25429-preview-3095034", | ||
| "Microsoft.VisualStudio.clrdbg.MIEngine": "14.0.30628-preview-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that I accidentally missed Wes's MIEngine commit from yesterday in this build. I kicked off a new build with that. We probably should take that too.
|
We should update README.md with a 'What's new' before we post the .vsix. I will send in a PR real quick. |
|
In addition, I hope to have OmniSharp ready today. I'm just finishing up installing the additional distros so I can test. |
|
@DustinCampbell, we have Fedora, openSuse, Linux Mint, Oracle Linux distros which we can give you remote access |
e4e297f to
0de9d6e
Compare
|
Ok, updated version to 1.2.0, update MIEngine version, removed import definitions from install.ts |
@gregg-miskelly @chuckries @rajkumar42 @DustinCampbell