Skip to content

Conversation

@gregg-miskelly
Copy link
Contributor

No description provided.

@gregg-miskelly
Copy link
Contributor Author

@wesrupert
Copy link
Contributor

👍

README.md Outdated

* The C# extension now only supports [.NET Core RC2](https://blogs.msdn.microsoft.com/dotnet/2016/05/16/announcing-net-core-rc2/). It no longer supports .NET Core RC1 or ASP .NET 5 RC1.
* **Support for .csproj projects is partially functional on OS X and Linux.** This will impact anyone doing .csproj development on OS X or Linux (e.g. Unity, Xamarin, etc.). We are working to address this in the near future. However, for now, you can use the [Legacy C# Support extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode.omnisharp).
* The C# extension now only supports [.NET Core RC2](https://blogs.msdn.microsoft.com/dotnet/2016/05/16/announcing-net-core-rc2/) and newer. It no longer supports .NET Core RC1 or ASP .NET 5 RC1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed. Obviously, we don't just support .NET Core RC2 any longer. I'm wondering if we should just remove this and the line you're adding. Instead of listing this as a breaking change, I wonder if it's better to add text somewhere above this that says that we officially support .NET Core 1.0 and not bother mentioning the breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DustinCampbell Just to be clear, I didn't add the line -- I just modified it to say 'and newer'.

So how does this sound?

  • Version the title to '... as of 1.2'
  • Change the first line to something like: 'The C# extension now only supports .NET Core 1.0. Please upgrade any RC2 projects to the 1.0.0 release build.

If so, sounds good to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine with me. Are you OK if I take another sweep through this after you merge? I've got a mail thread with a bunch of suggestions for our readme that I'd like to plow through.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@gregg-miskelly
Copy link
Contributor Author

@DustinCampbell please review again

@DustinCampbell
Copy link
Member

👍

@gregg-miskelly gregg-miskelly merged commit 72175f1 into dotnet:master Jun 29, 2016
@gregg-miskelly gregg-miskelly deleted the ReadMeUpdate-1.2.0 branch June 29, 2016 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants