-
Notifications
You must be signed in to change notification settings - Fork 727
Update README.md for 1.2.0 #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for 1.2.0 #499
Conversation
|
See https://github.com/gregg-miskelly/omnisharp-vscode/tree/ReadMeUpdate-1.2.0#c-for-visual-studio-code-powered-by-omnisharp for the formatted version of the doc |
|
👍 |
README.md
Outdated
|
|
||
| * The C# extension now only supports [.NET Core RC2](https://blogs.msdn.microsoft.com/dotnet/2016/05/16/announcing-net-core-rc2/). It no longer supports .NET Core RC1 or ASP .NET 5 RC1. | ||
| * **Support for .csproj projects is partially functional on OS X and Linux.** This will impact anyone doing .csproj development on OS X or Linux (e.g. Unity, Xamarin, etc.). We are working to address this in the near future. However, for now, you can use the [Legacy C# Support extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode.omnisharp). | ||
| * The C# extension now only supports [.NET Core RC2](https://blogs.msdn.microsoft.com/dotnet/2016/05/16/announcing-net-core-rc2/) and newer. It no longer supports .NET Core RC1 or ASP .NET 5 RC1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed. Obviously, we don't just support .NET Core RC2 any longer. I'm wondering if we should just remove this and the line you're adding. Instead of listing this as a breaking change, I wonder if it's better to add text somewhere above this that says that we officially support .NET Core 1.0 and not bother mentioning the breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DustinCampbell Just to be clear, I didn't add the line -- I just modified it to say 'and newer'.
So how does this sound?
- Version the title to '... as of 1.2'
- Change the first line to something like: 'The C# extension now only supports .NET Core 1.0. Please upgrade any RC2 projects to the 1.0.0 release build.
If so, sounds good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine with me. Are you OK if I take another sweep through this after you merge? I've got a mail thread with a bunch of suggestions for our readme that I'd like to plow through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
7ff6ec3 to
ef6e2c2
Compare
ef6e2c2 to
5da28da
Compare
|
@DustinCampbell please review again |
|
👍 |
No description provided.