Support using dual OmniSharp servers to improve handling of .csproj and project.json #585
Conversation
…OmniSharp 'flavor'
| "name": "csharp", | ||
| "publisher": "ms-vscode", | ||
| "version": "1.3.0", | ||
| "version": "1.3.0-beta1", |
There was a problem hiding this comment.
-beta1 [](start = 19, length = 6)
remove "-beta1"? #Closed
There was a problem hiding this comment.
Nope! 😄 See my email on releases that I sent last week.
Once I merge this, I'll put up a pre-release out of master for folks to test.
There was a problem hiding this comment.
To be clear, I'll change this when we merge to the release branch.
There was a problem hiding this comment.
|
|
| const options = this._readOptions(); | ||
|
|
||
| let flavor: omnisharp.Flavor; | ||
| if (options.path !== undefined && options.usesMono === true) { |
There was a problem hiding this comment.
If I am reading this correctly, one can use the 'usesMono' option to force the use of mono OmniSharp, but we don't have a corresponding option to force the use of CoreCLR omnisharp for folks who want to use CoreCLR omnisharp with a .csproj. Do I have that right?
If so, would it make sense to also have a way to force CoreCLR for folks dealing with PCL projects targeting CoreCLR?
There was a problem hiding this comment.
That's not the intention here. Essentially, there's already an option to specify a path to a specific OmniSharp -- csharp.omnisharp. I've added a csharp.omnisharpUsesMono option that controls whether the OmniSharp specified via csharp.omnisharp should be launched via Mono or not. For CoreCLR, the user just has to point csharp.omnisharp to the CoreCLR executable and it'll be launched.
|
Otherwise LGTM |
4 participants
Fixes #529
This is a fairly large change that largely cleans up the OmniSharp acquisition and launching code, but also adds support for two OmniSharp servers:
Essentially, instead of assuming a specific OmniSharp server on a particular platform, this change includes the notion of an OmniSharp "flavor", which is either CoreCLR, Desktop, or Mono.
cc @gregg-miskelly, @chuckries, @caslan, @rajkumar42, @Pilchie