Remove System.Diagnostics.StackTrace from debugger install #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debugger was installing System.Diagnostics.StackTrace which it doesn't appear to actually need and, in the dev install scenarios at least, was causing a problem with pulling in the wrong version of System.Reflection.Metadata. This removes it so the the dev and shipping code pulls in the same set of assemblies.
Contributor
Author
|
@caslan please review |
Contributor
Author
|
@rajkumar42 @caslan ping |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debugger was installing System.Diagnostics.StackTrace which it doesn't appear to actually need and, in the dev install scenarios at least, was causing a problem with pulling in the wrong version of System.Reflection.Metadata. This removes it so the dev and shipping code pulls in the same set of assemblies.
Testing: Verified that if I create a .vsix the debugger install still succeeds and resulting debugger works for basic things. Also verified, with private OpenDebugAD7 bits, that exception stack traces still work.