Versioncheck #715
Merged
Versioncheck #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/coreclr-debug/activate.ts
Outdated
| // succesfully spawned 'dotnet --info', check the Version | ||
| if (semver.lt(dotnetInfo.Version, MINIMUM_SUPPORTED_DOTNET_CLI)) | ||
| { | ||
| let message = 'The .NET CLI tools on the path are too old. .NET Core debugging will ont be enabled. The minimum supported version is ' + MINIMUM_SUPPORTED_DOTNET_CLI + '. '; |
chuckries
force-pushed
the
versioncheck
branch
from
1b21da1 to
24e179d
Compare
Contributor
Author
This does a version check at the time we verify dotnet is on the path by running dotnet --info. We use semver to compare the cli version to a hard coded minimum cli version. If the check fails we use the same UI we already had for "dotnet not on path" with a different message.
chuckries
force-pushed
the
versioncheck
branch
from
24e179d to
cc293bf
Compare
Contributor
|
LGTM! |
Contributor
|
LGTM |
Contributor
Author
|
Fixes #618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a version check of the dotnet cli tools on the path. Give a good error message if the tools are too old.