Improve OmniSharp server logging #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private _appendCore(message: string): void { | ||
| if (this._atLineStart) { | ||
| if (this._indentLevel > 0) { |
Contributor
There was a problem hiding this comment.
Shouldn't we really be taking a dependency on leftpad here :)
Member
Author
There was a problem hiding this comment.
Possibly. Seems like overkill just to repeat some characters. Left pad expects a length to be passed. I suppose I could use it to generate the indent string like so:
leftPad('', this._indentLevel * 4, ' ');Not sure it's worth it. 😄
Member
Author
There was a problem hiding this comment.
I could also do something like this:
const indent = " ".repeat(this._indentLevel * 4);
Contributor
There was a problem hiding this comment.
To be clear, this was supposed to just be a joke based on the fact that the removal of leftpad from NPM broke the internet.
Member
Author
There was a problem hiding this comment.
I know. I was being ironic. Gosh! Why doesn't anyone understand me?
😄😄😄😄😄
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560
Initially, I'd just set out to add a timestamp to the OmniSharp server log for #560, but ended up rationalizing logging during the server start up and download steps.