Specify '--encoding utf-8' when launching OmniSharp server #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OmniSharp is updated. Pushing this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4, #140, #427
This addresses issues when communicating with OmniSharp with multibyte characters. Note that this is only half of the fix. Due to a subtle issue in OmniSharp, this change currently only fixes the encoding for requests sent to OmniSharp but responses are still received garbled. I've submitted a PR to OmniSharp which fixes the other side of the problem (OmniSharp/omnisharp-roslyn#628). Once I have a new build of OmniSharp in hand, I'll switch over to that which should fully fix the issues listed above.
Note: I decided to make the whitespace consist in server.ts as part of this change. Sorry about that! You can click the specific commit that fixes the issue to see what the fix looks like.