Add Telemetry for coreclr-debug acquisition #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
src/coreclr-debug.ts
Outdated
| return; | ||
| } | ||
|
|
||
| initializeTelemetry(context); |
Contributor
There was a problem hiding this comment.
Might want to move this to line 36 for now so that we do as little as possible when .NET CLI isn't installed.
Contributor
|
👍 |
Member
|
LGTM |
Contributor
Author
|
I realized I prepped this against master, should I change it to dev? or just merge into master? |
Member
|
go ahead and merged. I tagged our release in master already. |
chuckries
added a commit
that referenced
this pull request
Mar 10, 2016
Add Telemetry for coreclr-debug acquisition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wish I would have gotten this in yesterday... I'd like to potentially push out another version of the extension this week so we can get this in.