Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 23, 2025

Problem

The branch-snap.yml workflow had two jobs (check-script and bump-main-version) that were running in parallel without any dependency relationship. This meant that the version bump could potentially occur before the inter-branch merge completed, which could lead to timing issues or incorrect behavior.

Solution

Added a needs: check-script dependency to the bump-main-version job on line 16 of .github/workflows/branch-snap.yml. This ensures that:

  1. The check-script job (which performs the inter-branch merge via dotnet/arcade/.github/workflows/inter-branch-merge-base.yml) runs first
  2. The bump-main-version job waits for check-script to complete successfully
  3. Only after successful completion of the merge, the version bump job executes (when running on the main branch)

Changes

  • File: .github/workflows/branch-snap.yml
  • Change: Added needs: check-script to the bump-main-version job definition

This is a minimal, surgical change that establishes the proper execution order for the workflow jobs, ensuring the version bump happens only after the inter-branch merge completes.

Original prompt

On branch-snap.yml:15-15, Please update this to ensure that the bump-main-version job only runs after completion of the prior inter branch merge


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
@dibarbet dibarbet marked this pull request as ready for review October 23, 2025 22:50
@dibarbet dibarbet requested a review from a team as a code owner October 23, 2025 22:50
@dibarbet dibarbet merged commit 59e2e0f into main Oct 23, 2025
2 checks passed
@dibarbet dibarbet deleted the copilot/update-bump-main-version-job branch October 23, 2025 22:50
Copilot AI restored the copilot/update-bump-main-version-job branch October 23, 2025 22:50
Copilot AI changed the title [WIP] Update job execution order for bump-main-version Add job dependency to ensure bump-main-version runs after inter-branch merge Oct 23, 2025
Copilot finished work on behalf of dibarbet October 23, 2025 22:50
Copilot AI requested a review from dibarbet October 23, 2025 22:50
@dibarbet dibarbet deleted the copilot/update-bump-main-version-job branch October 23, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants