-
Notifications
You must be signed in to change notification settings - Fork 729
Remove cohosting setting and hardcode the value to true #8810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cohosting setting and hardcode the value to true #8810
Conversation
dibarbet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also drop down the max vsix size on teh artifact tests, so we don't lose the improvement?
https://github.com/dotnet/vscode-csharp/blob/main/test/lsptoolshost/artifactTests/vsix.test.ts
dibarbet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Not as exciting as I would have hoped, but with both from local builds of the extension:
this branch:
What's perhaps more interesting is that "Finish Activate" time was dreadful until I manually deleted my local |
interesting! -50ms isn't too bad (still have a lot of O# code). will try it out once we have an official build as well |

Part of dotnet/razor#12491
Removes the bits of the C# extension that are for the non-cohosting editor. The OmniSharp setting still works as normal. I did it in bits, so commit-at-a-time might make sense, but most of it is just deleting whole files so GitHub hopefully will do a decent job.
There is a bit more cleanup that could happen, and could move some things around now that there is only one Razor system, could remove the word "cohost" from everything etc. but didn't want to make the PR too painful. Will need follow ups anyway, as bits form Roslyn and Razor are removed etc.
Reduces the VSIX size by about 40mb. I'll be honest, I was hoping for more :P