-
Notifications
You must be signed in to change notification settings - Fork 728
Implement spport for using pipeTransport with attach #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit contains Andrew's changes for pipeTransport attach rebased on master.
|
@WardenGnaw please do a quick review |
WardenGnaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Also tested it on my end and it works.
|
👍 |
Implement support for using pipeTransport with attach (#918)
|
Are there detailed instructions somewhere on how to set this up? I want to attach to a dotnet core app running on an IoT Core device. |
|
@gregg-miskelly has written an example here. |
|
I get a strange error in the remote-attach output when I F5...
The command works when I run in in a cmd window. Also I'm doing a self-contained deploy. Do I need to do anything extra to get clrdbg to work? |
|
@munyirik do you mean Windows IoT Core? |
|
Yes I did |
|
@munyirik the process listing code that we have is only for Unix. You can explicitly add the process id, and I think that would work. Alternatively you could use VS + msvsmon. |
|
Doesn't look like I can put the Id explicitly...
I'm working on an update to https://marketplace.visualstudio.com/items?itemName=ms-iot.windowsiot. |
|
@munyirik based on your error message I think you did something wrong. You want something like this (see 'processId'). {
"name": ".NET Core IoT Remote Attach",
"type": "coreclr",
"request": "attach",
"processId": "1234",
"pipeTransport": {
"pipeProgram": "c:\\mytools\\plink.exe",
"pipeArgs": [ "-i", "c:\\users\\greggm\\ssh-key.ppk", "greggm@1.2.3.4", "-batch", "-t" ],
"debuggerPath": "c:\\clrdbg\\clrdbg",
"pipeCwd": "${workspaceRoot}"
},
"sourceFileMap": {
"/home/ExampleAccount/ExampleProject": "${workspaceRoot}"
}
}Assuming this works, well enough, I would add --
|
|
Thanks I'll try that. Where can I get a copy of clrdbg from that I can copy to my device? |
|
@munyirik good point. I was thinking you could just use the Windows version, but in thinking about this more, I realized that this isn't going to work - our Windows version isn't designed to run on OneCore Windows. Lets talk more offline. |
This commit contains Andrew's changes for pipeTransport attach rebased on master.