Ensure that reference conflicts are resolved in favor of the shared assemblies #5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the latest servicing release. THis is the default arcade behavior, thus let it generate the manifest.
ViktorHofer
approved these changes
May 13, 2025
Member
|
This probably needs an ask mode template and Tactics approval. |
Tanya-Solyanik
added
Servicing-consider
NOMERGE
Servicing-approved
and removed
Servicing-consider
labels
Member
|
@ViktorHofer I'm not familiar with this issue. Do you know if this should be merged now, or did we miss any boat? It seems like it should be fine at first glance. |
Member
|
Yes this one is ready and should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #4991
Customer impact:
Assemblies that are present in the shared location are unexpectedly copied to the app local.
Workaround:
remove extra assemblies post build or use
ExcludeAssetsproperty with thePackageReferencetag.Regression?
perceived as a regression, it depends on whether the package referenced explicitly in the project file is newer or not that the GA version of package from the shared location.
Details
Desktop package was not updating the PlatformManifest file with every servicing release. Instead, this file was checked in and versions were pinned to GA. We change this logic to keep them up-to-date with the latest servicing release. This is the default arcade behavior.
Verification:
Compare the platform manifest files.
In the new package manifest file all except the following assembly versions were updated:
D3DCompiler_47_cor3.dll|Microsoft.WindowsDesktop.App.Ref||10.0.22621.3233
PresentationNative_cor3.dll|Microsoft.WindowsDesktop.App.Ref||9.0.24.47404
System.Diagnostics.EventLog.Messages.dll|Microsoft.WindowsDesktop.App.Ref|9.0.0.0|0.0.0.0