Remove CPD to Microsoft.Private.Winforms temporarily #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #534 to master.
Removes CPD to
Microsoft.Private.Winformstemporarily, until updated C++/CLI toolset becomes available (see related issues below).This will help ensure that WindowsDesktop apps (i.e., WPF and WinForms apps) built out of dotnet/windowsdesktop and targeting the shared sdk are able to find and load the runtime bundled with the SDK itself.
The downside is that the runtime that is bundled with the SDK is not the runtime (i.e., the ref-assemblies corresponding to the runtime) that was used to build WinForms and WPF binaries. This is what the CPD (CoherentParentDependency) ensures happens correctly.
Removing the CPD ensures that the runtimeconfig.json embedded in the WindowsDesktop shared runtime points to the same runtime (
Microsoft.NetCore.App) that is bundled with the SDK.In an ideal world, WinForms and WPF would build against the version of
Microsoft.NetCore.Appthat will be eventually bundled into the SDK - and thus the CPD would continue to be retained indotnet/windowsdesktoprepo. Today, we are unable to ingest newer versions ofMicrosoft.NetCore.Appdue to tooling problems (see links/discussion below), so this workaround is being added.Related:
/cc @dotnet/wpf-developers, @mmitche, @wtgodbe, @RussKie , @AdamYoblick, @nguerrera, @dsplaisted, @ericstj, @tgani-msft, @jeffschwMSFT