Skip to content

Conversation

@vatsan-madhavan
Copy link
Member

Porting #534 to master.

Removes CPD to Microsoft.Private.Winforms temporarily, until updated C++/CLI toolset becomes available (see related issues below).

This will help ensure that WindowsDesktop apps (i.e., WPF and WinForms apps) built out of dotnet/windowsdesktop and targeting the shared sdk are able to find and load the runtime bundled with the SDK itself.

The downside is that the runtime that is bundled with the SDK is not the runtime (i.e., the ref-assemblies corresponding to the runtime) that was used to build WinForms and WPF binaries. This is what the CPD (CoherentParentDependency) ensures happens correctly.

Removing the CPD ensures that the runtimeconfig.json embedded in the WindowsDesktop shared runtime points to the same runtime (Microsoft.NetCore.App) that is bundled with the SDK.

In an ideal world, WinForms and WPF would build against the version of Microsoft.NetCore.App that will be eventually bundled into the SDK - and thus the CPD would continue to be retained in dotnet/windowsdesktop repo. Today, we are unable to ingest newer versions of Microsoft.NetCore.App due to tooling problems (see links/discussion below), so this workaround is being added.

Related:

/cc @dotnet/wpf-developers, @mmitche, @wtgodbe, @RussKie , @AdamYoblick, @nguerrera, @dsplaisted, @ericstj, @tgani-msft, @jeffschwMSFT

@vatsan-madhavan
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vatsan-madhavan vatsan-madhavan merged commit fa26520 into dotnet:master Mar 4, 2020
@vatsan-madhavan vatsan-madhavan deleted the make-incoherent-wrt-winforms branch March 4, 2020 20:26
vatsan-madhavan added a commit to wpfcontrib/windowsdesktop that referenced this pull request Apr 8, 2020
…s CPD in preparation of resuming ingestion of dotnet/runtime updates into dotnet/winforms -> dotnet/wpf -> dotnet/windowsdesktop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants