KeysConverter should use CurrentUICulture when converting to name in default context.

[Tanya-Solyanik]

KeysConverter in NET8 started converting keys to strings based on the CurrentCulture -

winforms/src/System.Windows.Forms/src/System/Windows/Forms/Input/KeysConverter.cs

Lines 332 to 354 in f7d6850

	private IList<string> GetDisplayOrder(CultureInfo? culture)
	{
	// Use CurrentCulture as default to match other TypeConverters.
	culture ??= CultureInfo.CurrentCulture;
	if (!CultureToDisplayOrder.ContainsKey(culture))
	{
	AddLocalizedKeyNames(culture);
	}
	return CultureToDisplayOrder[culture];
	}
	private IDictionary<string, Keys> GetKeyNames(CultureInfo? culture)
	{
	// Use CurrentCulture as default to match other TypeConverters.
	culture ??= CultureInfo.CurrentCulture;
	if (!CultureToKeyName.ContainsKey(culture))
	{
	AddLocalizedKeyNames(culture);
	}
	return CultureToKeyName[culture];
	}

However, in .NET Framework, we were looking up names based on the CurrentUICulture - https://referencesource.microsoft.com/#System.Windows.Forms/winforms/Managed/System/WinForms/KeysConverter.cs,64 from the resources like this:

AddKey(SR.GetString(SR.toStringPageDown), Keys.Next);

this code goes to ResourceManager.GetString Method (System.Resources) | Microsoft Learn
and returns

The value of the resource localized for the caller's current UI culture, or null if name cannot be found in a resource set.

Originally posted by @cadilhac in #10610 (comment)

[elachlan]

I'd like to see this change, but what about the comment?
// Use CurrentCulture as default to match other TypeConverters.

We use CultureInfo.CurrentCulture all over the place and don't use CultureInfo.CurrentUICulture for whatever reasons. When should we be using CurrentUICulture over CurrentCulture?

The change was made in #8401

[Tanya-Solyanik]

Comment refers to https://github.com/dotnet/runtime/blob/9f8f6531b72c44da09d5ffcadf638f11cf51d227/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeConverter.cs#L49
I guess that TypeConverter is not optimized for UI while this converter has been using the UI culture in .NET Framework.

[merriemcgaw]

@LeafShi1 can you please have your team fix this as a follow up to the previous servicing you all did?