[Darc-Update] Update dependencies from build 20181029.8 of https://github.com/dotnet/arcade#11
Merged
dotnet-maestro[bot] merged 1 commit intomasterfrom Oct 30, 2018
Conversation
Contributor
Author
Auto-Merge StatusThis pull request has been merged because the following merge policies have succeeded.
|
dotnet-maestro
bot
deleted the
darc-master-50da426a-d762-4b5a-9fb5-340d1a4ad1d5
branch
Merged
RussKie
added a commit
to RussKie/winforms
that referenced
this pull request
Mar 17, 2020
* Rework the public button API: - Remove enums TaskDialogResult and TaskDialogButtons - Replace existing button classes with TaskDialogButton and TaskDialogCommandLinkButton - Create static "factory properties" that return new instances of TaskDialogButton representing a standard (common) button - Change static ShowDialog() methods to allow to pass an IEnumerable<TaskDialogButton> and return a TaskDialogButton Fixes kpreisser#5 * Use a better way to detect whether a TDN_BUTTON_CLICKED notification was caused by our own code sending a TDM_CLICK_BUTTON message. * Improve formatting. * Add property TaskDialogButton.DialogResult that can be used to retrieve the TaskDialogResult value of the button, and add a few CustomN enum values. * Reformat <return> tag (dotnet#11) * Revert "Add property TaskDialogButton.DialogResult that can be used to retrieve the TaskDialogResult value of the button, and add a few CustomN enum values." This reverts commit 6a73a75. * Use local variable. * Shift the default button assignment to the dialog (dotnet#10) * Shift the default button assignment to the dialog The original design allowed a user to mark multiple buttons as default. In this situation there will be a RTE, which is not the best devex/UX. Shift assignment of the default button to the dialog. This way the API are similar to the MessageBox API, and the user is able to assign onle one button. If the button doesn't belong to the collection of buttons - there will be a RTE. * Resolve a few TODOs. * Follow-Up: Update public API. * Revert unintended changes caused by editing the file in VS. Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the dependencies from https://github.com/dotnet/arcade to the following