Issue 12353 fix detach context menu strip memory leak#12399
Merged
LeafShi1 merged 5 commits intodotnet:mainfrom Nov 4, 2024
Merged
Issue 12353 fix detach context menu strip memory leak#12399LeafShi1 merged 5 commits intodotnet:mainfrom
LeafShi1 merged 5 commits intodotnet:mainfrom
Conversation
Member
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12399 +/- ##
====================================================
- Coverage 75.63691% 49.17370% -26.46322%
====================================================
Files 3147 1991 -1156
Lines 635806 284160 -351646
Branches 47012 41731 -5281
====================================================
- Hits 480904 139732 -341172
+ Misses 151456 141732 -9724
+ Partials 3446 2696 -750
Flags with carried forward coverage won't be shown. Click here to find out more. |
kirsan31
reviewed
Oct 29, 2024
LeafShi1
force-pushed
the
Issue_12353_fix_DetachContextMenuStrip_MemoryLeak
branch
3 times, most recently
from
c8e0d8e to
929659e
Compare
LeafShi1
force-pushed
the
Issue_12353_fix_DetachContextMenuStrip_MemoryLeak
branch
from
929659e to
a6a4ac9
Compare
Tanya-Solyanik
added
the
waiting-author-feedback
dotnet-policy-service
Bot
removed
the
waiting-author-feedback
Tanya-Solyanik
approved these changes
Nov 1, 2024
Tanya-Solyanik
added
the
ready-to-merge
LeafShi1
deleted the
Issue_12353_fix_DetachContextMenuStrip_MemoryLeak
branch
dotnet-policy-service
Bot
removed
the
ready-to-merge
paul1956
pushed a commit
to paul1956/winforms
that referenced
this pull request
Nov 5, 2024
* Removing reference to ContextMenuStrip when dispose control * Merge 'main' to current branch * Detach ContextMenuStrip from control when executing Dispose * Use pattern matching for judge variable menu
Contributor
|
Verified this issue in the latest .NET 10.0 SDK build: 10.0.100 - alpha.1.24556.12, it was fixed as following: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #12353
Proposed changes
Customer Impact
Regression?
Screenshots
Before
When the ContextMenuStrip property is set on a control, a memory leak will occur
After
No memory leak when ContextMenuStrip property is set on a control
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow