Skip to content

Conversation

@gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Mar 3, 2025

Proposed changes

  • Enable nullability in WindowsFormsDesignerOptionService.
Microsoft Reviewers: Open in CodeFlow

@Tanya-Solyanik
Copy link
Contributor

Error message
Assert.Empty() Failure: Collection was not empty\r\nCollection: [[]]

Stack trace
at System.Windows.Forms.Design.Tests.WindowsFormsDesignerOptionServiceTests.WindowsFormsDesignerOptionService_Options_GetNullDesignerOptions_ReturnsExpected() in D:\a_work\1\s\src\System.Windows.Forms.Design\tests\UnitTests\System\Windows\Forms\Design\WindowsFormsDesignerOptionServiceTests.cs:line 45
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@Tanya-Solyanik
Copy link
Contributor

@gpetrou - this PR is almost ready, is it OK with you if we take it over and finish up?

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Apr 3, 2025
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.24042%. Comparing base (4bcc8a9) to head (bf6b89e).
Report is 211 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13059          +/-   ##
====================================================
- Coverage   96.95044%   62.24042%   -34.71002%     
====================================================
  Files           1225        1556         +331     
  Lines         357134      159202      -197932     
  Branches        5537       14854        +9317     
====================================================
- Hits          346243       99088      -247155     
- Misses         10049       59363       +49314     
+ Partials         842         751          -91     
Flag Coverage Δ
Debug 62.24042% <100.00000%> (-34.71003%) ⬇️
integration 11.31896% <0.00000%> (?)
production 40.37199% <100.00000%> (?)
test 95.66723% <ø> (-1.28321%) ⬇️
unit 37.72444% <100.00000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik Tanya-Solyanik merged commit 8199f84 into dotnet:main Apr 16, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 16, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting-author-feedback The team requires more information from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants