Skip to content

Conversation

@KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented May 6, 2025

Fixes #13258
Fixes #13450

ScreenCapture

Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann self-assigned this May 6, 2025
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label May 6, 2025
@KlausLoeffelmann KlausLoeffelmann added security Issues of runtime code vulnerabilities or unintentional exposing customer data side effect and removed area-DarkMode Issues relating to Dark Mode feature labels May 6, 2025
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label May 6, 2025
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_ScreenCaptureMode branch from 5bb55db to cdb602f Compare May 6, 2025 15:41
@hyperquantum
Copy link

The difference between HideContent and HideWindow is unclear without looking at their description, and the names seem to differ from their actual meaning:

/// <summary>
///  The form or control appears blacked out in screenshots.
/// </summary>
HideContent = 1,

/// <summary>
///  The form or control appears blurred in screenshots.
/// Requires Windows 10 version 2004 or higher.
/// </summary>
HideWindow = 2

Why not rename them to CoverContent and BlurContent or something similar?

And it may be useful to document what will happen when value 2 is used but the code is run on a system that does not meet the minimum operating system requirement.

@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_ScreenCaptureMode branch from cdb602f to d61e0a5 Compare May 9, 2025 22:17
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 14.10359% with 1078 lines in your changes missing coverage. Please review.

Project coverage is 50.83404%. Comparing base (72ee6eb) to head (191df05).
Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (72ee6eb) and HEAD (191df05). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (72ee6eb) HEAD (191df05)
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13416          +/-   ##
====================================================
- Coverage   75.43847%   50.83404%   -24.60443%     
====================================================
  Files           3230        2063        -1167     
  Lines         639097      287636      -351461     
  Branches       47289       42054        -5235     
====================================================
- Hits          482125      146217      -335908     
+ Misses        147952      138596        -9356     
+ Partials        9020        2823        -6197     
Flag Coverage Δ
Debug 50.83404% <14.10359%> (-24.60443%) ⬇️
integration 18.72954% <6.13546%> (?)
production 50.83404% <14.10359%> (+2.42195%) ⬆️
test ?
unit 48.25926% <14.02390%> (-0.15284%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_ScreenCaptureMode branch from 1fcf6ca to a267b75 Compare May 11, 2025 20:14
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_ScreenCaptureMode branch from a267b75 to 191df05 Compare May 14, 2025 15:36
@KlausLoeffelmann KlausLoeffelmann deleted the NewApi_d_ScreenCaptureMode branch May 16, 2025 22:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

draft draft PR security Issues of runtime code vulnerabilities or unintentional exposing customer data side effect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let's consider to rename ScreenCaptureMode into FormScreenCaptureMode [API Suggestion][Security] Add ExcludeFromScreenCapture API to Forms/Controls

2 participants