Skip to content

Conversation

@KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented May 16, 2025

Fixes #13258.
Fixes #13450.

Looks like this, when recorded:

ScreenCapture

Microsoft Reviewers: Open in CodeFlow

@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label May 16, 2025
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label May 16, 2025
@KlausLoeffelmann KlausLoeffelmann marked this pull request as ready for review May 17, 2025 00:42
@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner May 17, 2025 00:42
@codecov
Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 28.01220% with 1416 lines in your changes missing coverage. Please review.

Project coverage is 76.47085%. Comparing base (8484b55) to head (964fdd7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13467         +/-   ##
===================================================
- Coverage   76.59415%   76.47085%   -0.12331%     
===================================================
  Files           3230        3240         +10     
  Lines         639165      640274       +1109     
  Branches       47297       47412        +115     
===================================================
+ Hits          489563      489623         +60     
- Misses        146025      147075       +1050     
+ Partials        3577        3576          -1     
Flag Coverage Δ
Debug 76.47085% <28.01220%> (-0.12331%) ⬇️
integration 18.72600% <16.47178%> (-0.05692%) ⬇️
production 50.82008% <28.01220%> (-0.17572%) ⬇️
test 97.40411% <ø> (ø)
unit 48.20362% <26.33452%> (-0.19768%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann KlausLoeffelmann removed the draft draft PR label May 17, 2025
@KlausLoeffelmann KlausLoeffelmann changed the base branch from main to klaus/preview5/C May 17, 2025 17:15
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_FormScreenCaptureMode branch 2 times, most recently from 495667c to 62384ee Compare May 21, 2025 15:57
LeafShi1 and others added 3 commits May 22, 2025 09:03
Update Pre-Release Iteration and Resource Management Milestone to
preview6
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/13483)
[main] Source code updates from dotnet/dotnet
[main] Source code updates from dotnet/dotnet
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_FormScreenCaptureMode branch from 62384ee to eb3fc86 Compare May 23, 2025 14:30
dotnet-maestro bot added 2 commits May 24, 2025 02:49
[main] Source code updates from dotnet/dotnet
[main] Source code updates from dotnet/dotnet
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_FormScreenCaptureMode branch 2 times, most recently from 5785869 to 90e44d8 Compare May 26, 2025 07:16
@KlausLoeffelmann KlausLoeffelmann changed the base branch from klaus/preview5/C to main May 26, 2025 07:29
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_FormScreenCaptureMode branch from 90e44d8 to 9a9bf28 Compare May 26, 2025 20:45
dotnet-maestro bot and others added 2 commits May 27, 2025 02:45
[main] Source code updates from dotnet/dotnet
…he value to a new text box (dotnet#13526)

I think we forgot to update *pdwEffect after _owner.OnDragDrop(dragEvent);
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_FormScreenCaptureMode branch from f737be8 to 964fdd7 Compare May 27, 2025 18:33
@KlausLoeffelmann KlausLoeffelmann changed the base branch from main to klaus/preview5/C May 27, 2025 21:34
KlausLoeffelmann and others added 26 commits May 28, 2025 20:19
* CheckBoxes,
* RadioButtons
* Tabs.

Also:

* Move ApplyThemingImplicitly flag definition to CreateParams.
* Update approach to set ApplyThemingImplicitly control style.
* Delegate FlatStyle.Standard Button rendering to the System due to HighDpi issues in the VisualStyle-based renderers.
* By that, implement new architecture for extendeble DarkMode/Style renderers.
@KlausLoeffelmann KlausLoeffelmann force-pushed the NewApi_d_FormScreenCaptureMode branch from 964fdd7 to 8f381a8 Compare May 29, 2025 03:21
@KlausLoeffelmann KlausLoeffelmann deleted the NewApi_d_FormScreenCaptureMode branch June 6, 2025 06:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-DarkMode Issues relating to Dark Mode feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let's consider to rename ScreenCaptureMode into FormScreenCaptureMode [API Suggestion][Security] Add ExcludeFromScreenCapture API to Forms/Controls

4 participants