Dark mode (g) fix combo box renderer #13502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Pre-Release Iteration and Resource Management Milestone to preview6 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/13483)
[main] Source code updates from dotnet/dotnet
[main] Source code updates from dotnet/dotnet
KlausLoeffelmann
force-pushed
the
DarkMode_g_FixComboBoxRenderer
branch
from
87e4d23 to
9ef2994
Compare
[main] Source code updates from dotnet/dotnet
KlausLoeffelmann
force-pushed
the
DarkMode_g_FixComboBoxRenderer
branch
3 times, most recently
from
203787d to
9ef2994
Compare
[main] Source code updates from dotnet/dotnet
KlausLoeffelmann
force-pushed
the
DarkMode_g_FixComboBoxRenderer
branch
from
9ef2994 to
80e1794
Compare
KlausLoeffelmann
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13502 +/- ##
===================================================
- Coverage 76.59415% 76.47392% -0.12023%
===================================================
Files 3230 3240 +10
Lines 639165 640298 +1133
Branches 47297 47415 +118
===================================================
+ Hits 489563 489661 +98
- Misses 146025 147060 +1035
Partials 3577 3577
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KlausLoeffelmann
force-pushed
the
DarkMode_g_FixComboBoxRenderer
branch
from
80e1794 to
325a438
Compare
[main] Source code updates from dotnet/dotnet
…he value to a new text box (dotnet#13526) I think we forgot to update *pdwEffect after _owner.OnDragDrop(dragEvent);
KlausLoeffelmann
force-pushed
the
DarkMode_g_FixComboBoxRenderer
branch
from
325a438 to
992a23a
Compare
Switch to a concurrent backing collection. Note that we only ever create them if you ask for them on the current thread.
* CheckBoxes, * RadioButtons * Tabs. Also: * Move ApplyThemingImplicitly flag definition to CreateParams. * Update approach to set ApplyThemingImplicitly control style. * Delegate FlatStyle.Standard Button rendering to the System due to HighDpi issues in the VisualStyle-based renderers.
* By that, implement new architecture for extendeble DarkMode/Style renderers.
KlausLoeffelmann
force-pushed
the
DarkMode_g_FixComboBoxRenderer
branch
from
992a23a to
716c1f6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dark mode issues around the ComboBox.
Microsoft Reviewers: Open in CodeFlow