Add IsHandleCreated checks before calling SetWindowPos in DesignerFrame #14086
+13
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14081
Proposed changes
IsHandleCreatedguard inParentOverlay()before callingSetParentandSetWindowPosIsHandleCreatedcheck inWndProcWM_PARENTNOTIFY handler before callingSetWindowPoson overlay controlsCustomer Impact
Control.Handlewithout a created handle forcesCreateHandle(), which can crash the designerRegression?
Risk
Control.BringToFront(),Control.SendToBack())Test methodology
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
96bvsblobprodcus338.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/winforms/winforms/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/winforms/winforms/artifacts/toolset/11.0.0-beta.25575.110.txt(dns block)/home/REDACTED/work/winforms/winforms/.dotnet/dotnet dotnet build src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj --no-restore(dns block)rcxvsblobprodcus328.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet dotnet build src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj --no-restore(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow