Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 21, 2026

Package source mapping in NuGet.config is incompatible with VMR backflow operations - stable backflow requires NuGet.config updates on every flow, and internal validation backflow requires extensive mapping rework per run. Limited security value given all feeds are MS-owned.

Changes

  • NuGet.config: Removed <packageSourceMapping> section (all 12 package sources remain intact)
  • eng/Analyzer.props: Added NU1507 to NoWarn to suppress package source mapping warnings
<!-- Suppress NU1507 (Package source mapping is not compatible with VMR backflow operations) -->
<NoWarn>$(NoWarn);NU1507</NoWarn>
Original prompt

This section details on the original issue you should resolve

<issue_title>VMR backflow is incompatible with package source mapping</issue_title>
<issue_description>winforms added package source mapping to its Nuget.config. This is incompatible with some practices:

I recommend removing the package source mapping and suppressing NU1507. The package source mapping is of limited utility given these are all MS owned feeds.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Microsoft Reviewers: Open in CodeFlow

Co-authored-by: mmitche <8725170+mmitche@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove package source mapping from Nuget.config Remove package source mapping to enable VMR backflow Jan 21, 2026
Copilot AI requested a review from mmitche January 21, 2026 22:46
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.19200%. Comparing base (9c45a8c) to head (9e83b48).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #14233         +/-   ##
===================================================
+ Coverage   77.18007%   77.19200%   +0.01192%     
===================================================
  Files           3279        3279                 
  Lines         645129      645129                 
  Branches       47728       47728                 
===================================================
+ Hits          497911      497988         +77     
+ Misses        143538      143462         -76     
+ Partials        3680        3679          -1     
Flag Coverage Δ
Debug 77.19200% <ø> (+0.01192%) ⬆️
integration 18.99716% <ø> (+0.01533%) ⬆️
production 52.08046% <ø> (+0.02676%) ⬆️
test 97.40479% <ø> (ø)
unit 49.53997% <ø> (+0.04692%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Jan 21, 2026
@mmitche mmitche marked this pull request as ready for review January 22, 2026 15:57
@mmitche mmitche requested a review from a team as a code owner January 22, 2026 15:57
@Shyam-Gupta Shyam-Gupta merged commit 49ba9d3 into main Jan 22, 2026
8 checks passed
@Shyam-Gupta Shyam-Gupta deleted the copilot/remove-package-source-mapping branch January 22, 2026 19:09
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VMR backflow is incompatible with package source mapping

3 participants