[release/10.0] Fix Clipboard.GetDataObject().GetImage regression for bitmap images#14462
Merged
Shyam-Gupta merged 7 commits intorelease/10.0from Apr 13, 2026
Merged
Conversation
…d test that depended on the old GetData fallback.
…jectTests.cs and adding a "delegation relationship" test for the `GetImage` method.
…jectTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/10.0 #14462 +/- ##
======================================================
- Coverage 77.10846% 77.10484% -0.00362%
======================================================
Files 3273 3273
Lines 645033 645062 +29
Branches 47702 47704 +2
======================================================
- Hits 497375 497374 -1
- Misses 143984 144011 +27
- Partials 3674 3677 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
Approved over email. |
Shyam-Gupta
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14423
main branch commit #14427
Description/Customer Impact
In .NET 10/11, it is not possible to use
Clipboard.GetDataObject().GetImage()API to retrieve images from the Clipboard. This API returns null.Root cause
In .NET 10, Clipboard was updated to use the new typed + NRBF pipeline. In this new approach, bitmap images are stored mainly in the
ITypedDataObjecttyped store, butDataObject.GetImagestill reads from the legacyGetDatastore and hence theClipboard.GetDataObject().GetImage()can no longer see those images on .NET 10/11 and returns null.Fix
Updated
DataObject.GetImage()API to useTryGetData<Image>(DataFormats.Bitmap, autoConvert: true, out image)which returns image using the new typed/NRBF code.Regression
Regression from .NET 9.0. Introduced by commit #11545
Risk
Very low. Another public API,
Clipboard.GetImage()already usesTryGetData<T>API and is working fine.Testing
Manual testing and added unit test for this scenario
Microsoft Reviewers: Open in CodeFlow