Skip to content

[Accessibility][ScreenReader]: Fixing tooltip text announcing by NVDA/Narrator #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2019
Merged

[Accessibility][ScreenReader]: Fixing tooltip text announcing by NVDA/Narrator #2074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/System.Windows.Forms/src/System/Windows/Forms/ToolTip.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,17 @@ private void AdjustBaseFromAuto()
_delayTimes[(int)ComCtl32.TTDT.INITIAL] = _delayTimes[(int)ComCtl32.TTDT.AUTOMATIC];
}

/// <summary>
/// ScreenReader announces ToolTip text for an element
/// </summary>
private void AnnounceText(Control tool, string text)
{
tool?.AccessibilityObject?.RaiseAutomationNotification(
Automation.AutomationNotificationKind.ActionCompleted,
Automation.AutomationNotificationProcessing.All,
ToolTipTitle + " " + text);
}

private void HandleCreated(object sender, EventArgs eventargs)
{
// Reset the toplevel control when the owner's handle is recreated.
Expand Down Expand Up @@ -2068,6 +2079,11 @@ private void WmShow()
e.Cancel = true;
}

if (!e.Cancel)
{
AnnounceText(toolControl, GetCaptionForTool(toolControl));
}

// We need to re-get the rectangle of the tooltip here because
// any of the tooltip attributes/properties could have been updated
// during the popup event; in which case the size of the tooltip is
Expand Down