[Accessibility][ScreenReader]: Fixing tooltip text announcing by NVDA/Narrator #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/3.1 #2074 +/- ##
=====================================================
+ Coverage 26.4715% 26.51825% +0.04675%
=====================================================
Files 806 806
Lines 268111 268121 +10
Branches 38071 38073 +2
=====================================================
+ Hits 70973 71101 +128
+ Misses 192056 191941 -115
+ Partials 5082 5079 -3
|
Member
|
Business case approved for 3.1 from the feature team side. |
Member
|
@vladimir-krestov has the test team verified this fix already? Are you ready for review now? |
RussKie
added
the
waiting-for-testing
Contributor
Author
|
Not tested yet. |
RussKie
reviewed
Oct 14, 2019
vladimir-krestov
changed the title
RussKie
previously approved these changes
Oct 14, 2019
vladimir-krestov
force-pushed
the
dev/v-vlkres/NVDAToolTipError
branch
from
ffb67ef to
2dd7fe1
Compare
Contributor
Author
|
Changed the implementation. |
Contributor
Author
|
The fix has some test issues. |
vladimir-krestov
added
🚧 work in progress
vladimir-krestov
changed the title
zsd4yr
reviewed
Oct 18, 2019
| /// </summary> | ||
| private void AnnounceText(Control tool, string text) | ||
| { | ||
| tool?.AccessibilityObject.RaiseAutomationNotification( |
Contributor
There was a problem hiding this comment.
Should you use the elvis operator ? after AccessibilityObject as well?
Contributor
There was a problem hiding this comment.
Any need to validate Automation is not null?
Contributor
Author
There was a problem hiding this comment.
You are right. Sometimes AccessibleObject property returns null. I need to handle it.
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed.
vladimir-krestov
changed the title
Contributor
Author
|
#2096 is merged, so I can to continue work on this PR. |
vladimir-krestov
added
waiting-for-testing
vladimir-krestov
force-pushed
the
dev/v-vlkres/NVDAToolTipError
branch
from
2dd7fe1 to
3914bb7
Compare
Contributor
Author
|
Testers approved this fix. ✔️ |
vladimir-krestov
added
📫 waiting-approval
and removed
waiting-for-testing
vladimir-krestov
changed the title
RussKie
approved these changes
Oct 25, 2019
leecow
added
servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073
Original bug: 987952
Proposed changes
- Add IToolTip interface and implement it to unite elements (Control, ToolStripItem, DataGridViewElement) which can have a tooltip (this is necessary to the correct, simple and short implementation of raising UIA notification.)Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow