Skip to content

Implementing UIA supporting for Form control #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2019
Merged

Implementing UIA supporting for Form control #2096

merged 3 commits into from
Oct 22, 2019

Conversation

@vladimir-krestov
Copy link
Contributor

@vladimir-krestov vladimir-krestov commented Oct 16, 2019 •
edited
Loading

Issue description

Proposed changes

  • Set SupportsUiaProviders property as true
  • Use FormAccessibleObject as AccessibleObject instead default

This allows customizing Form AccessibleObject how we want.
For example, fix UIA navigation in the accessibility tree. It changes the focus order of Narrator.
Form AccessibleObject works as before.

Customer Impact

  • Improved Bounds No

Regression?

  • No

Risk

  • No

Test methodology

  • Manual UI testing

Accessibility testing

  • Using Inspect tool

Test environment(s)

  • .NET Core Version: 3.1.0-preview1.19458.7
  • Microsoft Windows [Version 10.0.18362.356]
Microsoft Reviewers: Open in CodeFlow

@vladimir-krestov vladimir-krestov added this to the 3.1 milestone Oct 16, 2019
@vladimir-krestov vladimir-krestov requested a review from a team as a code owner October 16, 2019 14:59
@vladimir-krestov vladimir-krestov self-assigned this Oct 16, 2019
@vladimir-krestov vladimir-krestov mentioned this pull request Oct 16, 2019
Merged
@codecov
Copy link

codecov bot commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #2096 into release/3.1 will decrease coverage by 0.05208%.
The diff coverage is 4%.

@@                  Coverage Diff                  @@
##           release/3.1       #2096         +/-   ##
=====================================================
- Coverage      26.5056%   26.45352%   -0.05208%     
=====================================================
  Files              805         806          +1     
  Lines           268083      268108         +25     
  Branches         38068       38070          +2     
=====================================================
- Hits             71057       70924        -133     
- Misses          191947      192096        +149     
- Partials          5079        5088          +9
Flag Coverage Δ
#Debug 26.45352% <4%> (-0.05209%) ⬇️
#production 26.45352% <4%> (-0.05209%) ⬇️
#test 100% <ø> (ø) ⬆️

RussKie
RussKie reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/System.Windows.Forms/src/System/Windows/Forms/Form.cs Outdated
/// This inherits from the base ControlAccessibleObject
/// to have all base functionality.
/// </summary>
internal class FormAccessibleObject : ControlAccessibleObject
Copy link
Contributor

@RussKie RussKie Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be placed in a separate file? e.g. Form.FormAccessibleObject.cs

Copy link
Contributor Author

@vladimir-krestov vladimir-krestov Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll change this file location.

Copy link
Contributor Author

@vladimir-krestov vladimir-krestov Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file location is changed.

@RussKie RussKie added the waiting-author-feedback The team requires more information from the author label Oct 17, 2019
@vladimir-krestov vladimir-krestov changed the title Implementing UIA supporting for Form control WIP: Implementing UIA supporting for Form control Oct 17, 2019
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Oct 17, 2019
@vladimir-krestov vladimir-krestov added the 🚧 work in progress Work that is current in progress label Oct 17, 2019
@vladimir-krestov vladimir-krestov changed the title WIP: Implementing UIA supporting for Form control Implementing UIA supporting for Form control Oct 17, 2019
@vladimir-krestov vladimir-krestov removed the 🚧 work in progress Work that is current in progress label Oct 17, 2019
@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Oct 17, 2019

Needs review and approve before testing.

RussKie
RussKie previously approved these changes Oct 17, 2019
View reviewed changes
@vladimir-krestov vladimir-krestov added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 17, 2019
@RussKie
Copy link
Contributor

RussKie commented Oct 18, 2019

Please don't forget to squash

@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Oct 18, 2019

I'll squash commits after testing before final approval. Thanks for reminding.

@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Oct 18, 2019

Removed Bounds implementation because it breaks RT test cases. At the moment Form AccessibleObject the same as before, but supports UIA provider.

@merriemcgaw
Copy link
Member

merriemcgaw commented Oct 18, 2019

business case approved. Please add ask-mode when ready with the tested fix.

zsd4yr
zsd4yr previously approved these changes Oct 18, 2019
View reviewed changes
@RussKie RussKie added waiting-review This item is waiting on review by one or more members of team and removed waiting-review This item is waiting on review by one or more members of team labels Oct 22, 2019
@vladimir-krestov vladimir-krestov removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 22, 2019
@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Oct 22, 2019

Testers approved the fix. ✔️
But Bounds property and BoundingRectangle property don't match.
BoundingRectangle is the correct yellow rectangle of Inspect.
Bounds made as before the fix. All automation tests passed.

@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/FormUIAAccessibleObject branch from c757dd5 to f24fd7e Compare October 22, 2019 08:18
@merriemcgaw merriemcgaw added servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria ask-mode and removed waiting-approval servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Oct 22, 2019
@leecow leecow added the servicing-approved .NET Shiproom approved the PR for merge label Oct 22, 2019
@RussKie RussKie removed the ask-mode label Oct 22, 2019
@RussKie RussKie merged commit 274b4c1 into release/3.1 Oct 22, 2019
@RussKie RussKie deleted the dev/v-vlkres/FormUIAAccessibleObject branch October 22, 2019 23:55
@vladimir-krestov vladimir-krestov mentioned this pull request Aug 31, 2021
Closed
70 tasks
@Danil-Andrianov Danil-Andrianov mentioned this pull request Nov 1, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@RussKie RussKie RussKie approved these changes

@zsd4yr zsd4yr zsd4yr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vladimir-krestov vladimir-krestov

Labels

servicing-approved .NET Shiproom approved the PR for merge

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

6 participants

@vladimir-krestov @RussKie @merriemcgaw @zsd4yr @leecow