Skip to content

Update readme to refer to v3.1 and link to breaking changes#2529

Merged
RussKie merged 9 commits into
dotnet:masterfrom
RussKie:update_readmes
Dec 20, 2019
Merged

Update readme to refer to v3.1 and link to breaking changes#2529
RussKie merged 9 commits into
dotnet:masterfrom
RussKie:update_readmes

Conversation

@RussKie
Copy link
Copy Markdown
Contributor

@RussKie RussKie commented Dec 19, 2019

Resolves #2501

Proposed changes

  • Update readmes to include links to breaking changes between .NET Framework and .NET Core versions
  • Remove out-dated sections
  • Update readmes to refer to v3.1 instead of 3.0
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2019

Codecov Report

Merging #2529 into master will increase coverage by 0.32724%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master       #2529         +/-   ##
===================================================
+ Coverage   54.68909%   55.01633%   +0.32723%     
===================================================
  Files           1412        1414          +2     
  Lines         402647      404838       +2191     
  Branches       38867       38885         +18     
===================================================
+ Hits          220204      222727       +2523     
+ Misses        177068      176756        -312     
+ Partials        5375        5355         -20
Flag Coverage Δ
#Debug 55.01633% <ø> (+0.32724%) ⬆️
#production 30.54821% <ø> (+0.11987%) ⬆️
#test 98.8492% <ø> (+0.0172%) ⬆️

Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some comments...

Comment thread Documentation/getting-started.md
Comment thread Documentation/issue-guide.md Outdated
1. Use **up-for-grabs** as much as possible, ideally with a quick note about next steps / complexity of the issue.
* Note: Per [http://up-for-grabs.net][up-for-grabs-net], such issues should be no longer than few nights' worth of work. They should be actionable (i.e. no mysterious CI failures that can't be tested in the open).
1. Use **up-for-grabs** as much as possible, ideally with a quick note about next steps / complexity of the issue.<br />
NB: Per [http://up-for-grabs.net][up-for-grabs-net], such issues should be no longer than few nights' worth of work. They should be actionable (i.e. no mysterious CI failures that can't be tested in the open).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is NB?

i.e. -> that is,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread Documentation/porting-guidelines.md Outdated
Comment thread Documentation/porting-guidelines.md Outdated
Comment thread Documentation/porting-guidelines.md Outdated
Comment thread Documentation/porting-guidelines.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
RussKie and others added 8 commits December 20, 2019 12:50
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@RussKie
Copy link
Copy Markdown
Contributor Author

RussKie commented Dec 20, 2019

Thank you @mairaw, appreciate the review

@RussKie RussKie merged commit c135845 into dotnet:master Dec 20, 2019
@RussKie RussKie deleted the update_readmes branch December 20, 2019 04:14
@ghost ghost added this to the 5.0 milestone Dec 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read me for Visual Studio and Core releases do not highlight breaking changes

2 participants