Update readme to refer to v3.1 and link to breaking changes#2529
Merged
Conversation
0f999a7 to
0523a9b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
===================================================
+ Coverage 54.68909% 55.01633% +0.32723%
===================================================
Files 1412 1414 +2
Lines 402647 404838 +2191
Branches 38867 38885 +18
===================================================
+ Hits 220204 222727 +2523
+ Misses 177068 176756 -312
+ Partials 5375 5355 -20
|
mairaw
reviewed
Dec 19, 2019
| 1. Use **up-for-grabs** as much as possible, ideally with a quick note about next steps / complexity of the issue. | ||
| * Note: Per [http://up-for-grabs.net][up-for-grabs-net], such issues should be no longer than few nights' worth of work. They should be actionable (i.e. no mysterious CI failures that can't be tested in the open). | ||
| 1. Use **up-for-grabs** as much as possible, ideally with a quick note about next steps / complexity of the issue.<br /> | ||
| NB: Per [http://up-for-grabs.net][up-for-grabs-net], such issues should be no longer than few nights' worth of work. They should be actionable (i.e. no mysterious CI failures that can't be tested in the open). |
Contributor
There was a problem hiding this comment.
What is NB?
i.e. -> that is,
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
It is also listed in https://ahdictionary.com/word/search.html?q=nb
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Contributor
Author
|
Thank you @mairaw, appreciate the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2501
Proposed changes
Microsoft Reviewers: Open in CodeFlow