Skip to content

WIP: Fixing Narrator caps navigation to take into account control tab index #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

WIP: Fixing Narrator caps navigation to take into account control tab index #3037

wants to merge 9 commits into from

Conversation

@M-Lipin
Copy link
Contributor

@M-Lipin M-Lipin commented Apr 3, 2020 •
edited
Loading

Fixes #2164

Proposed changes

  • Adding UIA navigation to the Form control;
  • Adding UIA support for Control;
  • Adding UIA previous and next navigation to base Control.

Customer Impact

  • Narrator caps navigation will take into account control tab index.
  • There will be no mismatch between common tab navigation accompanied with Narrator announcement and Narrator caps navigation.

Regression?

  • No

Risk

  • Middle risk as requires switching to UIA for all controls. Need to rebase on 5.0.

Screenshots

Before

image

After

  • To be added (work in progress).

Test methodology

  • To be tested.

Accessibility testing

  • To be added.

Test environment(s)

  • To be added.

Initial PR: #2167

Microsoft Reviewers: Open in CodeFlow

@M-Lipin M-Lipin requested a review from a team as a code owner April 3, 2020 12:09
@ghost ghost assigned M-Lipin Apr 3, 2020
@M-Lipin M-Lipin mentioned this pull request Apr 3, 2020
Closed
3 tasks
Mikhail Lipin and others added 6 commits April 13, 2020 17:25
Fixing tab navigation for cases with tab index is not specified, for …
8db3f50 
…case when current child is not specified (first or last child in the form), for case when some controls have same tab index.
Fixing null-reference exception when accessing current child.
9f15a34
Fixing the issue with siblings that have same tab index.
96cd0bc
@AleksandrBeliaev
Adding UIA support for Button, Label, TextBox, GroupBox, PictureBox, …
913d402 
…RadioButton and ListView controls
Clean-up resx file.
a0bb476
@M-Lipin
Merge pull request #1 from M-Lipin/dev/v-alebe/Issue_2164_Narrator_ca…
4fbc782 
…ps_navigation

Adding UIA accessible objects for Label, Button, Splitter, GroupBox, PictureBox, CheckBox and ListView controls.
@M-Lipin M-Lipin mentioned this pull request May 4, 2020
Merged
@M-Lipin
Copy link
Contributor Author

M-Lipin commented May 4, 2020

❗ Please do not review at this moment as the controls' changes will be moved to separate PRs.

@vladimir-krestov vladimir-krestov mentioned this pull request Jun 10, 2020
Closed
70 tasks
@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Sep 9, 2020

Will be reopened when UIA support is implemented for all controls

This was referenced May 27, 2021
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@M-Lipin M-Lipin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Narrator focus is not moving in proper logical order when user is navigating by using caps + arrow keys (tab index is ignored)

3 participants

@M-Lipin @vladimir-krestov @AleksandrBeliaev