Fixing issue 3206: Label control accessibility reworking #3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
hughbe
reviewed
May 5, 2020
src/System.Windows.Forms/src/System/Windows/Forms/Label.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
hughbe
reviewed
May 5, 2020
RussKie
suggested changes
May 6, 2020
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LabelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
waiting-author-feedback
hughbe
reviewed
May 12, 2020
src/System.Windows.Forms/src/System/Windows/Forms/Label.LabelImageIndexer.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3208 +/- ##
====================================================
- Coverage 62.14766% 33.04910% -29.09856%
====================================================
Files 1257 868 -389
Lines 449428 254013 -195415
Branches 39227 36752 -2475
====================================================
- Hits 279309 83949 -195360
- Misses 164638 165250 +612
+ Partials 5481 4814 -667
|
Ryuugamine
force-pushed
the
Issue_3206_Label_control_UIA_accessibility
branch
from
c043254 to
86274a4
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RussKie
reviewed
Jun 22, 2020
src/System.Windows.Forms/src/System/Windows/Forms/Label.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.LabelImageIndexer.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.LabelImageIndexer.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.LabelImageIndexer.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.LabelImageIndexer.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Label.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
Ryuugamine
force-pushed
the
Issue_3206_Label_control_UIA_accessibility
branch
from
1d4c811 to
aad4969
Compare
added 2 commits
July 6, 2020 11:36
Ryuugamine
force-pushed
the
Issue_3206_Label_control_UIA_accessibility
branch
from
a406564 to
733648a
Compare
RussKie
approved these changes
Jul 6, 2020
RussKie
removed
the
waiting-author-feedback
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit tests.
Fixes #3206
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
.NET Core 5.0
Version: 5.0.100-alpha.1.20073.10
Commit: 29f4d693a9
Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\5.0.100-alpha1-05536\
Host (useful for support):
Version: 5.0.0-alpha.1.20072.3
Commit: c3dc1fdfdc
Microsoft Reviewers: Open in CodeFlow