Skip to content

More yaml fixes for private github repo #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamYoblick merged 10 commits into from
Oct 24, 2018
Merged

More yaml fixes for private github repo #4

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
db2fbb8
Yaml changes to support private github repo
AdamYoblick Oct 24, 2018
568f953
whoops, fixing copy paste
AdamYoblick Oct 24, 2018
8eb8de5
Fix whitespace in yaml
AdamYoblick Oct 24, 2018
79babec
fixing yaml expressions
AdamYoblick Oct 24, 2018
82aa023
yaml expression fixes
AdamYoblick Oct 24, 2018
79e2b0b
fixing whitespace. I hate yaml.
AdamYoblick Oct 24, 2018
37c0e5b
More yaml fixes to support private github repo
AdamYoblick Oct 24, 2018
22cc9ed
Merge branch 'master' into yamlfixes
AdamYoblick Oct 24, 2018
da203d9
Merge branch 'master' into yamlfixes
AdamYoblick Oct 24, 2018
730e787
More yaml fixes for private github repo
AdamYoblick Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions eng/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ phases:
${{ insert }}: ${{ parameters.variables }}
_HelixBuildConfig: $(_BuildConfig)
# Only enable publishing in non-public, non PR scenarios.
${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
# TODO: Once we go public, remove the build definition name check
${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest'), not(contains(variables['Build.DefinitionName'], 'github'))) }}:
# This should be changed to an isolated blob feed per-build.
# Right now a manual build of a random branch would get published alongside the normal branch artifacts.
_PublishBlobFeedUrl: https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json
Expand All @@ -41,13 +42,15 @@ phases:
/p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat)
_OfficialBuildIdArgs: /p:OfficialBuildId=$(BUILD.BUILDNUMBER)
# else
${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
# TODO: Once we go public, remove the build definition name check
${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest'), contains(variables['Build.DefinitionName'], 'github')) }}:
_PublishArgs: ''
_OfficialBuildIdArgs: ''
_SignArgs: ''

steps:
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
# TODO: Once we go public, remove the build definition name check
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest'), not(contains(variables['Build.DefinitionName'], 'github'))) }}:
- task: AzureKeyVault@1
inputs:
azureSubscription: 'DotNet-Engineering-Services_KeyVault'
Expand Down