Skip to content

Net FX 48 Accessibility Fixes port#400

Merged
M-Lipin merged 4 commits into
masterfrom
dev/v-milipi/NetFx48AccessibilityFixesPort
Feb 7, 2019
Merged

Net FX 48 Accessibility Fixes port#400
M-Lipin merged 4 commits into
masterfrom
dev/v-milipi/NetFx48AccessibilityFixesPort

Conversation

@M-Lipin
Copy link
Copy Markdown
Contributor

@M-Lipin M-Lipin commented Jan 30, 2019

Porting accessibility fixes for DataGridView, ToolStrip and PropertyGrid controls.

contributes to #182

@M-Lipin M-Lipin requested a review from a team as a code owner January 30, 2019 20:37
@dnfclas
Copy link
Copy Markdown

dnfclas commented Jan 30, 2019

CLA assistant check
All CLA requirements met.

@zsd4yr
Copy link
Copy Markdown
Contributor

zsd4yr commented Jan 30, 2019

@M-Lipin is this ready for code review? Could you resolve the CLA check?

@Tanya-Solyanik once this is ready, will you be the one to review these changes?

@Tanya-Solyanik
Copy link
Copy Markdown
Contributor

@M-Lipin - Looks reasonable, could you please describe how you diff'ed and tested this change? Looking at the change, I'm pretty sure you did not override anything new in Core, but did you get everything from the "desktop"?

@M-Lipin
Copy link
Copy Markdown
Contributor Author

M-Lipin commented Feb 4, 2019

@Tanya-Solyanik - I diffed all the fixes from "desktop" (which are implemented after introducing WinForms to .NET Core) one by one with the Core source code. Basically I took the fix changeset that went to NetFXDev1, diffed all the changes, merged to Core and saved the corresponding Core files. Then I took the next bug changeset (in time order: firstly I took the oldest changeset, then the newer one) and incremented or overwrote the changes (if there were newer changes in the same files and same code lines).

I tested the changes by creating the test Core WinForms application with all updated controls: ComboBox, DataGridView, PropertyGrid and performed some basic tests: UI works as expected, accessibility fixes (tested in Inspect and Narrator) are presented in Core WinForms app.

There is nothing new in Core in comparison with "desktop", all the accessibility fixes that I implemented earlier should be in this port.

@zsd4yr
Copy link
Copy Markdown
Contributor

zsd4yr commented Feb 4, 2019

@M-Lipin looks like there is a build error in the PR. Please take a look by clicking on Details down here next to the dotnet-winforms CI check, then View more details on Azure Pipelines on the bottom of the resulting page. (direct link). Click on either Job (Debug or Release) and then click on the build step to see the log and error.

Looks like there is an issue with SR files being out of sync and that you need to run msbuild /t:UpdateXlf locally and push again to resolve.

@M-Lipin M-Lipin merged commit 784d45b into master Feb 7, 2019
@M-Lipin M-Lipin deleted the dev/v-milipi/NetFx48AccessibilityFixesPort branch February 7, 2019 11:00
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants