Correct EnumVariantObject definition (servicing)#4209
Merged
RussKie merged 1 commit intoNov 20, 2020
Merged
Conversation
…ect method in EnumVariantObject for EnumVariantObject The fix allows users to see the correct accessibility tree of controls that don't support UIA using Inspect tool Fixes dotnet#4120 (LinkLabel accessiblity tree) Fixes dotnet#4121 (CheckedListBox accessiblity tree) The regression from 0c4d3cb (cherry picked from commit 5af42bf)
RussKie
added
the
servicing-consider
RussKie
changed the title
EnumVariantObject definitionEnumVariantObject definition (servicing)
Codecov Report
@@ Coverage Diff @@
## release/5.0 #4209 +/- ##
=====================================================
- Coverage 68.04802% 68.04645% -0.00158%
=====================================================
Files 1419 1419
Lines 509765 509765
Branches 41478 41478
=====================================================
- Hits 346885 346877 -8
- Misses 156646 156653 +7
- Partials 6234 6235 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
@vladimir-krestov could you do a quick sanity check to confirm all is good? Thanks |
Contributor
|
Confirm, ❌ the previous commit (61c7831) doesn't work for:
After applying the fix (checkout your branch) all of them work correctly now. ✔️ |
RussKie
added
a11y-MAS
vladimir-krestov
approved these changes
Nov 13, 2020
leecow
added
servicing-approved
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 5af42bf)
Fixes #4120 (
LinkLabelaccessiblity tree)Fixes #4121 (
CheckedListBoxaccessiblity tree)Fixes #4130 (MSAA
UpDowncontrols)Fixes #4172 (MSAA
CheckedListBox)Regression from 0c4d3cb
Proposed changes
currentChildfromuinttointbefore using in Marshal.GetNativeVariantForObjectCustomer Impact
Regression?
Risk
Screenshots
Before
CheckedListBoxdoesn't have internal items AccessibleObjects in the accessibility treeAfter
CheckedListBoxhas the correct accessibility tree with the internal itemsTest methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow