Adding support for text pattern to ComboBox #4540

SergeySmirnov-Akvelon · 2021-02-08T13:50:30Z

Fixes #4409

Proposed changes

Added ComboBoxUiaTextProvider class to support TextPattern. Its logic is based on the TextBoxBaseUiaTextProvider, but we use the native control handle, which is responsible for editing
Added unit tests

Customer Impact

Before:

After:

Regression?

Yes, from Accessibility: The list item of comboBox incorrectly displayed in inspect tree when setting its DropDownStyle as DropDown or DropDownList. #3654

Risk

Minimal

Test methodology

Unit tests
Manual testing
CTI team

Accessibility testing

Inspect
Narrator

Test environment(s)

Microsoft Windows [Version 10.0.19041.388]
.NET Core SDK 5.0.200-preview.20614.14

Microsoft Reviewers: Open in CodeFlow

codecov · 2021-02-08T14:11:46Z

Codecov Report

Merging #4540 (ae34ee4) into main (55216f2) will increase coverage by 0.00461%.
The diff coverage is 99.60106%.

@@                 Coverage Diff                 @@
##                main       #4540         +/-   ##
===================================================
+ Coverage   97.97367%   97.97828%   +0.00460%     
===================================================
  Files            543         544          +1     
  Lines         264666      265418        +752     
  Branches        5007        5089         +82     
===================================================
+ Hits          259303      260052        +749     
  Misses          4483        4483                 
- Partials         880         883          +3

Flag	Coverage Δ
Debug	`97.97828% <99.60106%> (+0.00460%)`	⬆️
production	`?`
test	`97.97828% <99.60106%> (+0.00460%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

vladimir-krestov

Good work. So many tests!
Main review point - return real hardcode values instead calculating

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.ComboBoxChildEditUiaProvider.cs

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.ComboBoxUiaTextProvider.cs

....Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBox.ComboBoxUiaTextProviderTests.cs

vladimir-krestov

Looks good

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.ComboBoxUiaTextProvider.cs

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.cs

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.ComboBoxChildEditUiaProvider.cs

SergeySmirnov-Akvelon · 2021-03-11T07:24:06Z

CTI approved

RussKie · 2021-03-16T23:24:25Z

MC

SergeySmirnov-Akvelon · 2021-03-18T05:34:21Z

MC are fixed :)

src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Automation/UiaTextRange.cs

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.cs

RussKie · 2021-03-18T06:08:54Z

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.cs

What's a correlation between _childEdit and ChildEditAccessibleObject?

During the creation of the Handle for the ComboBox, we create a _childEdit. _childEdit is used when creating a ChildEditAccessibleObject. Thus, if _childEdit exists, we can be sure that the ChildEditAccessibleObject exists or can be created.

src/System.Windows.Forms/src/System/Windows/Forms/ComboBox.ComboBoxUiaTextProvider.cs

…pDown, Simple) should support ValuePattern and TextPattern dotnet#4409 Added ComboBoxUiaTextProvider class to support TextPattern. Its logic is based on the TextBoxBaseUiaTextProvider, but we use the native control handle, which is responsible for editing Changed the value of the "nativeDebugging" flag to "false", because the text pattern works incorrectly without this in the "WinFormTests" project Added unit tests

RussKie · 2021-03-22T01:41:53Z

....Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBox.ComboBoxUiaTextProviderTests.cs

+        [InlineData(ComboBoxStyle.Simple)]
+        public void ComboBoxUiaTextProvider_Ctor_DoesntCreateControlHandle(ComboBoxStyle dropDownStyle)
+        {
+            using (new NoAssertContext())


In most cases you can do this:

Suggested change

using (new NoAssertContext())

using NoAssertContext context = new();

It the same, just less braces and indentation.

SergeySmirnov-Akvelon requested a review from a team as a code owner February 8, 2021 13:50

ghost assigned SergeySmirnov-Akvelon Feb 8, 2021

SergeySmirnov-Akvelon force-pushed the Issue-4409_adding_support_for_text_pattern_to_combobox branch from 462690e to 9a2fc76 Compare February 10, 2021 13:05

vladimir-krestov reviewed Feb 13, 2021

View reviewed changes

RussKie added the waiting-author-feedback The team requires more information from the author label Feb 15, 2021

ghost removed the waiting-author-feedback The team requires more information from the author label Feb 15, 2021

SergeySmirnov-Akvelon force-pushed the Issue-4409_adding_support_for_text_pattern_to_combobox branch from 9a2fc76 to a014d9c Compare February 15, 2021 13:50

RussKie previously approved these changes Feb 16, 2021

View reviewed changes

SergeySmirnov-Akvelon added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Feb 16, 2021

vladimir-krestov previously approved these changes Feb 17, 2021

View reviewed changes

SergeySmirnov-Akvelon dismissed stale reviews from vladimir-krestov and RussKie via 63fc0fb March 9, 2021 11:11

vladimir-krestov previously approved these changes Mar 9, 2021

View reviewed changes

SergeySmirnov-Akvelon dismissed vladimir-krestov’s stale review via 6884412 March 9, 2021 13:57

SergeySmirnov-Akvelon force-pushed the Issue-4409_adding_support_for_text_pattern_to_combobox branch 4 times, most recently from 61984b3 to ba1b95f Compare March 10, 2021 12:51

SergeySmirnov-Akvelon added waiting-review This item is waiting on review by one or more members of team and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Mar 11, 2021

RussKie previously approved these changes Mar 16, 2021

View reviewed changes

RussKie added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 16, 2021

SergeySmirnov-Akvelon dismissed RussKie’s stale review via 0bb8d75 March 17, 2021 07:13

SergeySmirnov-Akvelon force-pushed the Issue-4409_adding_support_for_text_pattern_to_combobox branch from ba1b95f to 0bb8d75 Compare March 17, 2021 07:13

ghost removed the waiting-author-feedback The team requires more information from the author label Mar 17, 2021

RussKie reviewed Mar 18, 2021

View reviewed changes

RussKie added the waiting-author-feedback The team requires more information from the author label Mar 18, 2021

ghost removed the waiting-author-feedback The team requires more information from the author label Mar 18, 2021

SergeySmirnov-Akvelon force-pushed the Issue-4409_adding_support_for_text_pattern_to_combobox branch from 0bb8d75 to ae34ee4 Compare March 18, 2021 07:48

RussKie reviewed Mar 22, 2021

View reviewed changes

RussKie approved these changes Mar 22, 2021

View reviewed changes

RussKie merged commit 13d19eb into dotnet:main Mar 22, 2021

RussKie deleted the Issue-4409_adding_support_for_text_pattern_to_combobox branch March 22, 2021 01:42

ghost added this to the 6.0 Preview3 milestone Mar 22, 2021

Olina-Zhang mentioned this pull request Mar 31, 2021

[Accessibility] Narrator should announce "end of line'" instead of "Space" when focusing on last text position in comboBox and textBox #4749

Closed

vladimir-krestov mentioned this pull request Aug 31, 2021

Epic - [Accessibility] Implement UIA provider for all controls #3421

Closed

70 tasks

ghost locked as resolved and limited conversation to collaborators Jan 29, 2022

	using (new NoAssertContext())
	using NoAssertContext context = new();

Adding support for text pattern to ComboBox #4540

Adding support for text pattern to ComboBox #4540

Uh oh!

Conversation

SergeySmirnov-Akvelon commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

codecov bot commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SergeySmirnov-Akvelon commented Mar 11, 2021

Uh oh!

RussKie commented Mar 16, 2021

Uh oh!

SergeySmirnov-Akvelon commented Mar 18, 2021

Uh oh!

Uh oh!

Uh oh!

RussKie Mar 18, 2021

Choose a reason for hiding this comment

Uh oh!

SergeySmirnov-Akvelon Mar 18, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RussKie Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SergeySmirnov-Akvelon commented Feb 8, 2021 •

edited

Loading

codecov bot commented Feb 8, 2021 •

edited

Loading