Run selected tests in en-US culture#6985
Merged
RussKie merged 3 commits intodotnet:mainfrom Apr 26, 2022
Merged
Conversation
Contributor
|
Thanks, I'll cross reference with my local branch I pull in to adjust broken tests (an older version is also here but I haven't pushed it for a long time, that was just for commenting on an issue back then). Do you want this to be the resolution for #2734? If so I can do a PR to adress the affected tests. |
Tanya-Solyanik
previously approved these changes
Apr 8, 2022
dreddy-work
reviewed
Apr 8, 2022
dreddy-work
added
the
waiting-author-feedback
RussKie
force-pushed
the
run_tests_in_en-US_culture
branch
from
ac4ff29 to
d5b7870
Compare
ghost
removed
the
waiting-author-feedback
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mu OS default locale is set to "en-AU", and these tests kept failing for me. Add two new XUnit attributes to specify the desired locale.
/cc: @weltkante @vladimir-krestov I know that in the past you had troubles with some locale-dependent tests on your ends. If you could run these changes and confirm that (at least) these tests pass for you - it would be awesome.
Also, if you see any other tests that may benefit from the new decoration - please let me know (or sent a PR in :)).
Thank you.
Microsoft Reviewers: Open in CodeFlow