Adding AccessibleObject for ListViewItem's image by NikitaSemenovAkvelon · Pull Request #7672 · dotnet/winforms

NikitaSemenovAkvelon · 2022-08-26T05:39:57Z

Fixes #4690 Details.Case 2

Proposed changes

Added ListViewItemImageAccessibleObject
Used AO for image inside ListViewItemDetailsAccessibleObject
Added unit tests

Customer Impact

User can see information about ListViewItem's image via accessibility tools

Regression?

No

Risk

Minimal

Screenshots

Before

After

Test methodology

Manually
Unit tests
AI

Accessibility testing

AI

Test environment(s)

7.0.100-preview.7.22377.5

Microsoft Reviewers: Open in CodeFlow

Tanya-Solyanik

Looks good, please see my comments.

vladimir-krestov

It looks really complex. I would consider not using any index for the image AO at all. It will allow to keep the code more clear, we will just insert one object. But I will check if it work

Tanya-Solyanik · 2022-08-30T04:26:21Z

    <value>Gets or sets the parameter that is passed to the Command property's object on execution or on execution context request.</value>
  </data>
+  <data name="ListViewItemImageAccessibleObjectDescription" xml:space="preserve">
+    <value>Image of the ListViewItem.</value>


Does WPF have anything similar? I don't think that the current description is useful. Can we use "Image of <Item AccessibleName>" instead? Or even leave it empty?

RussKie · 2022-08-30T06:17:03Z

The resources are out of sync. Please rebase on top of the latest main.

dmitrii-drobotov

LGTM 👍

Tanya-Solyanik · 2022-08-30T19:18:59Z

It looks really complex.

I agree with Vladimir, maybe we can unify to having only one kind of index in the code and convert it right before it's returned to the accessibility tools. I'm not sure if conversion methods are much help ☹️

vladimir-krestov · 2022-08-30T19:42:41Z

I tried to rework it, but GetChild should return the image AO and subItems AO. So subItems start from 0, and there is only one way - to use -1 index for image AO child, but it doesn't looks correct. So we have to implement this converting algorithm. It will help us to insert checkBox AO if we will want.
One more point, @Tanya-Solyanik, may we name the Image AO as "sub item" and put inside GetDetailsSubItemOrFakeInternal? It is not a subitem and should not be here, in my opinion. But I didn't find a fast way to rework this implementation much better.

Tanya-Solyanik · 2022-08-31T18:26:08Z

may we name the Image AO as "sub item" and put inside GetDetailsSubItemOrFakeInternal?

If you think this change makes the code more readable, then sure. I'm concerned that when this code is maintained by somebody else, they would not be able to distinguish one index from the other.

Tanya-Solyanik

Looks good! I added some suggestions for naming.

Tanya-Solyanik · 2022-09-17T07:26:06Z

@dmitrii-drobotov - did you have a chance to re-review the latest?

Used AO for image inside ListViewItemImageAccessibleObject Added unit tests

Tanya-Solyanik · 2022-09-20T00:41:39Z

@dmitrii-drobotov - please re-review this change.

Tanya-Solyanik · 2022-09-20T00:42:25Z

@NikitaSemenovAkvelon - please send this change to testing.

dmitrii-drobotov

Looks good!

NikitaSemenovAkvelon · 2022-09-21T11:55:33Z

CTI detected an error that image bounds don't draw on mouse navigation in AI/Inspect. I've added a fix in a separate commit to clarity. After reviewing I'll squash it with the previous one.

Tanya-Solyanik

Please fix the tests.

Olina-Zhang · 2022-09-26T08:51:13Z

Tested this PR fixing with no new issue found finally.

* Added ListViewItemImageAccessibleObject Used AO for image inside ListViewItemImageAccessibleObject Added unit tests

NikitaSemenovAkvelon requested a review from a team as a code owner August 26, 2022 05:39

ghost assigned NikitaSemenovAkvelon Aug 26, 2022

NikitaSemenovAkvelon requested review from Tanya-Solyanik, dmitrii-drobotov, dreddy-work and vladimir-krestov August 26, 2022 05:40

NikitaSemenovAkvelon changed the title ~~Adding AccessibleObject for ListViewItem~~ Adding AccessibleObject for ListViewItem's image Aug 26, 2022

Tanya-Solyanik reviewed Aug 27, 2022

View reviewed changes

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch from 60fb54a to d83b172 Compare August 29, 2022 06:30

vladimir-krestov reviewed Aug 29, 2022

View reviewed changes

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch from d83b172 to ad165f0 Compare August 30, 2022 04:24

Tanya-Solyanik reviewed Aug 30, 2022

View reviewed changes

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch 3 times, most recently from 5be2f78 to 7a91efe Compare August 30, 2022 05:44

RussKie added the waiting-author-feedback The team requires more information from the author label Aug 30, 2022

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch from 7a91efe to e90041a Compare August 30, 2022 06:24

ghost removed the waiting-author-feedback The team requires more information from the author label Aug 30, 2022

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch from e90041a to d8e423e Compare August 30, 2022 06:32

dmitrii-drobotov reviewed Aug 30, 2022

View reviewed changes

Comment thread ...tem.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewItemImageAccessibleObject.cs Outdated

Comment thread ...m.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewItemDetailsAccessibleObject.cs Outdated

dmitrii-drobotov reviewed Aug 30, 2022

View reviewed changes

Comment thread ...m.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewItemDetailsAccessibleObject.cs Outdated

dmitrii-drobotov reviewed Aug 30, 2022

View reviewed changes

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch from d8e423e to de392c2 Compare August 31, 2022 07:57

Tanya-Solyanik reviewed Sep 17, 2022

View reviewed changes

Tanya-Solyanik added this to the 8.0 Preview1 milestone Sep 17, 2022

RussKie reviewed Sep 19, 2022

View reviewed changes

Comment thread ...m.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewItemDetailsAccessibleObject.cs Outdated

RussKie reviewed Sep 19, 2022

View reviewed changes

Comment thread ...m.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewItemDetailsAccessibleObject.cs Outdated

RussKie reviewed Sep 19, 2022

View reviewed changes

Comment thread ...m.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewItemDetailsAccessibleObject.cs Outdated

Added ListViewItemImageAccessibleObject

dea0733

Used AO for image inside ListViewItemImageAccessibleObject Added unit tests

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch from de392c2 to dea0733 Compare September 19, 2022 06:00

ghost removed the waiting-author-feedback The team requires more information from the author label Sep 19, 2022

runfoapp Bot mentioned this pull request Sep 19, 2022

Flaky test DataGridView_OnColumnHeadersHeightChanged_InvokeWithHandle_CallsColumnHeadersHeightChanged #6926

Closed

Tanya-Solyanik previously approved these changes Sep 20, 2022

View reviewed changes

Tanya-Solyanik added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Sep 20, 2022

dmitrii-drobotov previously approved these changes Sep 20, 2022

View reviewed changes

NikitaSemenovAkvelon dismissed stale reviews from dmitrii-drobotov and Tanya-Solyanik via f556107 September 21, 2022 11:52

Tanya-Solyanik previously approved these changes Sep 21, 2022

View reviewed changes

Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 21, 2022

Fixed focusing on ListViewItem's Image through mouse navigation

7888516

NikitaSemenovAkvelon dismissed Tanya-Solyanik’s stale review via 7888516 September 22, 2022 05:00

NikitaSemenovAkvelon force-pushed the Issue_4690-Added_ListViewItem_ListViewItemImageAccessibleObject branch from f556107 to 7888516 Compare September 22, 2022 05:00

ghost removed the waiting-author-feedback The team requires more information from the author label Sep 22, 2022

runfoapp Bot mentioned this pull request Sep 22, 2022

Flaky System.Windows.Forms.Tests.ToolStripTests.ToolStrip_WndProc_InvokeMouseActivate_Success #7333

Closed

Tanya-Solyanik approved these changes Sep 22, 2022

View reviewed changes

Olina-Zhang removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Sep 26, 2022

Tanya-Solyanik merged commit 39bb168 into dotnet:main Sep 26, 2022

v-elnovikova pushed a commit to v-elnovikova/winforms that referenced this pull request Oct 18, 2022

Adding AccessibleObject for ListViewItem's image (dotnet#7672)

00ad012

* Added ListViewItemImageAccessibleObject Used AO for image inside ListViewItemImageAccessibleObject Added unit tests

NikitaSemenovAkvelon mentioned this pull request Oct 25, 2022

[Accessibility] ArgumentOutOfRange exception is raised on selecting the last SubItem of ListViewItem in Details view if it has an image. #8025

Closed

ghost locked as resolved and limited conversation to collaborators Oct 27, 2022

Conversation

NikitaSemenovAkvelon commented Aug 26, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Screenshots

Before

After

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tanya-Solyanik Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RussKie commented Aug 30, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmitrii-drobotov left a comment

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik commented Aug 30, 2022

Uh oh!

vladimir-krestov commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tanya-Solyanik commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tanya-Solyanik commented Sep 17, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tanya-Solyanik commented Sep 20, 2022

NikitaSemenovAkvelon commented Aug 26, 2022 •

edited by ghost

Loading

Tanya-Solyanik Aug 30, 2022 •

edited

Loading

vladimir-krestov commented Aug 30, 2022 •

edited

Loading

Tanya-Solyanik commented Aug 31, 2022 •

edited

Loading