[release/8.0] fix bug PrintPreviewControl lacks UI Automation Scroll pattern support #9768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Olina-Zhang - Could you please test this PR. |
Member
|
Hi @Tanya-Solyanik, tested this PR with private binaries based on the latest .Net 8.0 RC2 build, now printPreviewControl supports ScrollPattern when it contains horizontal or vertical scrollbar. No new issue found. |
lonitra
approved these changes
Aug 23, 2023
github-actions
bot
force-pushed
the
backport/pr-9694-to-release/8.0
branch
from
f287605 to
6cddf33
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9694 to release/8.0
Fixes #9584
/cc @Tanya-Solyanik @Epica3055
Customer Impact
This is a regression introduced earlier in .NET 8.0 . When we implemented a custom UIA provider for Print preview control, instead of the standard one, we missed the scroll pattern. Scroll pattern is required for the Accessibility tools user to be able to access the full content of the document about to be printed.
Testing
Manual testing under Accessibility insights, narrator and Inspect to confirm that scrolling works.
Risk
The added code runs only under AT, risk is minimal.
Microsoft Reviewers: Open in CodeFlow