Additional COM fixes (#9769) #9780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COM code audit fixes: - AxContainer.IOleInPlaceFrame.SetActiveObject was not ref counting correctly or checking for null - OleInterfaces.IOleControlSite.GetExtendedControl was unnecessarily using Marshal - OleIntefaces.IOleInPlaceSite.GetWindowContext brought in line with MFC behavior with null pointers - Use SearchValues in ActiveXImpl (minor perf fix) - ActiveXImpl.InPlaceActivate was incorrectly ref counting - ActiveXImpl Save/Load were releasing IPropertyBag when it was passed directly from native code, move the using local to the internal code - ActiveXImpl.QuickActivate should not fail if we cannot get IConnectionPointContainer - Add DisposeHelper.NullAndRelease helper for safer release of pointer fields - Harden AgileComPointer a bit more by using Interlocked
ghost
assigned
lonitra
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #9769 - do not squash
COM code audit fixes:
Microsoft Reviewers: Open in CodeFlow