More COM audit fixes (#9776) #9797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional audit fixes: - IGetOleObject should be returning IOleObject, not IUnknown. Confirmed against VB6 code. - ClassPropertyDispatchAdapter was allowing conflicts with explicit [DispId] - Clarify code a bit in ClassPropertyDispatchAdapter.Invoke, use VARIANT marshalling, and allow no result in getter - Tweak ITypeLib import to throw for clarity in StandardDispatch - Validate DISPPARAMS parameter in StandardDispatch Invoke methods - Remove unused method in StandardDispatch - Add a few unit tests for ClassPropertyDispatchAdapterTests - Change namespace for IDispatchTests - Minor source cleaning in COM type descriptor code - Throw with OleCreatePropertyFrame as we used to. - Use ComHelpers for one missed IPerPropertyBrowsing usage in Com2IPerPropertyBrowsingEnum - Don't create in VARIANT for ExecuteBuilder call in COM2PropertyBuilderUITypeEditor (validated with all implementations in VS and Windows) - Com2PropertyDescriptor.SetValue should store the object not the VARIANT in last value and should free the VARIANT - Remove IErrorInfo wrapper and use the API directly - Use VARIANT method to get object in ProcessTypeInfoEnum - Add a simple test to validate interop behavior for int/uint and add comment to VARIANT
ghost
assigned
Shyam-Gupta
approved these changes
Aug 28, 2023
KlausLoeffelmann
approved these changes
Aug 28, 2023
src/System.Windows.Forms.Primitives/src/Interop/OleAut32/Interop.VARIANT.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #9776
Additional audit fixes:
Microsoft Reviewers: Open in CodeFlow