Copy file procedure fails in copy-wpf.ps1 file

[Simon-IT]

.NET Core Version: 3.0.100-preview9-014004
Windows version: 1903 (build SO 18362.356)
Does the bug reproduce also in WPF for .NET Framework 4.8?: not applicable

Problem description:
The macro doesn't copy the files because the source directory is targeted 3.0 yet.

Actual behavior:
The procedure exit without any message about fail.

Expected behavior:
All WPF files are copyed or a message that tells the source directory doesn't exists.

Maybe I was wrong but I've commit a solution to this bug and it appears in the pull request of another bug 1761
Please tell me how I should behave

[weltkante]

Please tell me how I should behave

PRs aren't commit based, each PR needs a separate branch (i.e. you don't want to work directly on master unless you only want to do a single PR at a time). You should probably clean this up by creating separate branches and cherry picking the individual commits into the branches.

[Simon-IT]

Thank you @weltkante. I'll follow your suggestion. About this, is it possible remove the commit from the pull request ?

[weltkante]

You can remove the commit in your repository (locally) and do a force-push when you upload, github should pick that up and reset the PR changes while keeping the discussion intact.

If you want to switch the branch the PR points to, not sure how that works, never had to do that on github but it seems possible. In this case its easier to setup a new branch, cherry-pick the commit you want on it, then change the PR to point to the new branch.

[Simon-IT]

I've done "revert" of the commit...

[Simon-IT]

@stevenbrix Sorry, what's the meaning of "up-for-grubs" ?

[stevenbrix]

@stevenbrix Sorry, what's the meaning of "up-for-grubs" ?

@Simon-IT, it means anyone can do this task if they want. Based on the above PR that you sent out that had the fix for this issue, I figured you might want to finish this one :)

[Simon-IT]

@stevenbrix I'm sorry if I ask so many questions, but I have to understand better how the contribution system works. So, can I open a PR with the solution of this ssue ?

[stevenbrix]

@Simon-IT,

I'm sorry if I ask so many questions, but I have to understand better how the contribution system works.

No worries! Have you read our documentation on contributing? Hopefully there is some information in there that is helpful. If not, we're always happy to answer your questions :)

So, can I open a PR with the solution of this ssue ?

Yes, please do! 👍