FontStyle and FontWeight localization

[DmitryRomenskiy]

Description

Hello,

I'm not really sure if this is the right repo or if this is the designed behavior. Please correct me if I am wrong.

I want to ask a question about the FontStyle and FontWeight structs.

We use these in our products to populate some combos so that users can adjust their selected fonts.

`
IEnumerable CreateFontWeights() {
yield return System.Windows.FontWeights.Normal;
yield return System.Windows.FontWeights.Bold;
yield return System.Windows.FontWeights.Thin;
}

IEnumerable CreateFontStyles() {
yield return System.Windows.FontStyles.Normal;
yield return System.Windows.FontStyles.Italic;
yield return System.Windows.FontStyles.Oblique;
}
`

When ann app is localized, our editors still display these values in English. I do not see a simple way to change this. Google brought me some related topics:
https://stackoverflow.com/questions/1472376/c-sharp-wpf-getting-localized-fontfamily
https://social.msdn.microsoft.com/Forums/en-US/995361e9-e3ac-4b2c-aab9-06bd311d734d/displaying-font-styles-in-localized-name

Is this the right way to localize these strings?

Configuration

.NET 5
Win 10
x64/x86
Nope

Regression?

Did not test previous versions, pretty sure it works the same way there.

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[singhashish-wpf]

Font Style and Font Weight items are from the enumeration type which are not localizable. If you want to localize, you'll need to add logic to map from the enum values to your specified strings.

[miloush]

The weights and styles are not enums. Moreover, the font weight can be an arbitrary number between 1 and 999.

Depending on the application, it might be more appropriate to list the styles/weights only present in given font, based on FontFamily.FamilyTypefaces.

Moreover, fonts can specify localized names for typefaces (subfamilies). If the selected font does so for your language, you should use the value from the font. In WPF, you need to get hold of a Typeface instance (not the same as FamilyTypeface), either by constructing it directly from the desired style/weight or if available in your application, via an instance of GlyphTypeface. These contain the localized names in the FaceNames property, for example:

new Typeface(new FontFamily("Arial"), FontStyles.Italic, FontWeights.Bold, FontStretches.Normal)
    .FaceNames[XmlLanguage.GetLanguage("ru-RU")] // Полужирный Курсив

You might need to do some fallback to not miss an acceptable localization, e.g. figure out de-DE from de-AT.

If the font does not have your language (and many don't), you are on your own. Either you fallback to a system font that you know comes localized and use its names, or you construct the name yourself.

The WPF's code that tries to come up with typeface names in English is in FontDifferentiator, using FontWeightToString, FontStyleStringToKnownStyle and, also, don't forget that many modern typeface uses varying degree of stretch - FontStretchToString. That should give you a starting point for consistent experience.

[DmitryRomenskiy]

Thank you, @miloush, I think we can proceed with that.