Remove PartialArray<T> in favor of Span<T> and avoid struct boxing#10009
Open
h3xds1nz wants to merge 3 commits intodotnet:mainfrom
Open
Remove PartialArray<T> in favor of Span<T> and avoid struct boxing#10009h3xds1nz wants to merge 3 commits intodotnet:mainfrom
h3xds1nz wants to merge 3 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the internal
PartialArray<T>which is basically duplicatingSpan<T>functionality (in cases where it is used, not globally, obviously). Since this is then passed toIList<T>params and used as an interface, the struct needs to be boxed on top of everything and most of those calls are done via dispatch instead of using it directly.Given how few places it is used, we can just replace it and remove the type altogether. In some places it was just used to wrap a regular array without any benefit.
The removed null-checks were really for
nullbut I've checked the call chains and there's no way it should ever benull(or it wouldn't matter if theSpan<T>was empty).Customer Impact
Increased performance, decreased allocations.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow