Skip to content

Add PackageReference to account for XamlAccessLevel move#1192

Merged
vatsan-madhavan merged 2 commits intomasterfrom
user/ojhad/addextensionspackagereferenceforXALmove
Jul 9, 2019
Merged

Add PackageReference to account for XamlAccessLevel move#1192
vatsan-madhavan merged 2 commits intomasterfrom
user/ojhad/addextensionspackagereferenceforXALmove

Conversation

@ojhad
Copy link
Copy Markdown

@ojhad ojhad commented Jul 8, 2019

Related to issue #1183

XamlAccessLevel was moved to System.Windows.Extensions.dll as part of the following PR: dotnet/corefx#38908
Updating System.Xaml.csproj to have this package reference so that when dependencies are updated, the type can be found in its new location

@ghost ghost requested review from rladuca, ryalanms, stevenbrix and vatsan-madhavan July 8, 2019 23:30
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 8, 2019
@ghost ghost requested a review from SamBent July 8, 2019 23:30
Add System.Windows.Extensions PackageReference to System.Xaml-ref.csproj
@vatsan-madhavan
Copy link
Copy Markdown
Member

This was missing a similar <PackageReference /> for System.Xaml-ref.csproj. I added it directly to the branch as a separate commit; completing this PR since we need this change immediately & @ojhad unavailable today.

@vatsan-madhavan vatsan-madhavan merged commit e061ef0 into master Jul 9, 2019
@vatsan-madhavan vatsan-madhavan deleted the user/ojhad/addextensionspackagereferenceforXALmove branch July 9, 2019 21:34
@vatsan-madhavan vatsan-madhavan restored the user/ojhad/addextensionspackagereferenceforXALmove branch July 9, 2019 21:35
@vatsan-madhavan vatsan-madhavan added this to the 3.0 milestone Jul 9, 2019
@vatsan-madhavan vatsan-madhavan deleted the user/ojhad/addextensionspackagereferenceforXALmove branch August 23, 2019 20:12
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants