Skip to content

Using array empty to replace create an empty array #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2021
Merged

Using array empty to replace create an empty array #2843

merged 2 commits into from
Feb 8, 2021

Conversation

@lindexi
Copy link
Member

@lindexi lindexi commented Apr 5, 2020

No description provided.

@ghost ghost requested review from rladuca and vatsan-madhavan April 5, 2020 02:14
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 5, 2020
@ghost ghost requested a review from SamBent April 5, 2020 02:14
@ryalanms ryalanms added Priority:2 Work that is important, but not critical for the release Queue for test pass labels Jan 5, 2021
@ryalanms ryalanms self-requested a review January 7, 2021 21:25
fabiant3
fabiant3 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@fabiant3 fabiant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission @lindexi. Curious if you have scrubbed the code for similar usage or these are all of our new object[0] instances?

@lindexi
Copy link
Member Author

lindexi commented Jan 7, 2021

Thanks for your submission @lindexi. Curious if you have scrubbed the code for similar usage or these are all of our new object[0] instances?

I'm not sure. lol

This was referenced Jan 11, 2021
Closed
Closed
@lindexi lindexi requested a review from a team as a code owner January 12, 2021 02:11
@ryalanms ryalanms mentioned this pull request Jan 27, 2021
Closed
@ryalanms
Copy link
Member

ryalanms commented Feb 8, 2021

Thank you for all these changes, @lindexi.

@ryalanms ryalanms merged commit 3115751 into dotnet:master Feb 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2022
@ghost ghost assigned lindexi May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryalanms ryalanms ryalanms approved these changes

@vatsan-madhavan vatsan-madhavan Awaiting requested review from vatsan-madhavan

@rladuca rladuca Awaiting requested review from rladuca

@SamBent SamBent Awaiting requested review from SamBent

+1 more reviewer

@fabiant3 fabiant3 fabiant3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lindexi lindexi

Labels

PR metadata: Label to tag PRs, to facilitate with triage Priority:2 Work that is important, but not critical for the release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lindexi @ryalanms @fabiant3 @dipeshmsft