Community PR test pass 1/18/2021 #3983
Conversation
ghost
requested review from
| static public void Trace( TraceEventType type, AvTraceDetails traceDetails ) | ||
| { | ||
| _avTrace.Trace( type, traceDetails.Id, traceDetails.Message, traceDetails.Labels, new object[0] ); | ||
| _avTrace.Trace( type, traceDetails.Id, traceDetails.Message, traceDetails.Labels, Array.Empty<object>() ); |
There was a problem hiding this comment.
This is a generated file (see comment at the top of the file). You need to make these changes in the template as well, or they'll get overwritten the next time the template changes.
The right way to do this change is:
a. Change the template file AvTraceMessages.tt
b. Re-run the generator to propagate the changes to the 3 AvTraceMessages.cs files (for Base, Core, and FW).
c. Check in all 4 changed files.
I think step (b) happens automatically at the start of a full build, but you should verify that.
ryalanms
added
the
* NO MERGE *
|
I will wait for Sam's sign-off before starting the test pass. If any other PRs come in before then, we can add them to this test run. |
|
I am still waiting on sign-offs to start the test pass. There are only two PRs, so this will have to wait until Monday. Thanks. |
ryalanms
changed the title
ghost
locked as resolved and limited conversation to collaborators
Community PR Test Pass 1/11/2021
These PRs will be merged if no regressions are found.
Community PRs included in this test branch:
Remove custom copy of PtrToStringChars #3117
Using array empty to replace create an empty array #2843
Test Matrix