Avoid new delegate allocation on each DispatcherTimer tick #4717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Member
|
Awesome! |
stephentoub
force-pushed
the
dispatchertimeralloc
branch
from
56d9805 to
3686a6a
Compare
stephentoub
force-pushed
the
dispatchertimeralloc
branch
from
3686a6a to
fdf4efc
Compare
kronic
reviewed
Jun 23, 2021
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/Threading/DispatcherTimer.cs
Show resolved
Hide resolved
ryalanms
approved these changes
Aug 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every time DispatcherTimer.Restart is called (which may happen on every tick), it's allocating a new delegate to point to the instance's FireTick method. We can instead make it a non-capturing delegate, such that the compiler caches it on first use and never has to allocate it again, passing in
thisvia the object state.Customer Impact
Less garbage allocated for the GC to clean up.
Regression
No
Testing
Only what's done by CI.
Risk
Minimal. The change just modifies how
thisis passed to the callback.