Skip to content

Avoid new delegate allocation on each DispatcherTimer tick #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Avoid new delegate allocation on each DispatcherTimer tick #4717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/Threading/DispatcherTimer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,8 @@ private void Restart()
// BeginInvoke a new operation.
_operation = _dispatcher.BeginInvoke(
DispatcherPriority.Inactive,
new DispatcherOperationCallback(FireTick),
null);
(DispatcherOperationCallback)(state => ((DispatcherTimer)state).FireTick()),
this);


_dueTimeInTicks = Environment.TickCount + (int) _interval.TotalMilliseconds;
Expand Down Expand Up @@ -297,7 +297,7 @@ internal void Promote() // called from Dispatcher
}
}

private object FireTick(object unused)
private object FireTick()
{
// The operation has been invoked, so forget about it.
_operation = null;
Expand Down