Only enable DisableImplicitNamespaceImports when UseWPF is set
#4868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Member
|
FWIW implicit namespace imports have been around for VB much longer than C#. I’d be surprised if they broke WPF, I suspect it’s had them for VB even on .NETFramework. |
vishalmsft
deleted the
scope.disable.implicit.namespace.imports.to.wpf
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinForms project also import Microsoft.WinFX.targets, and WinForms now relies on implicit imports. Scope disabling implicit imports to WPF. This broke WinForms VB projects.
/cc @dotnet/wpf-developers