Skip to content

Cherry-pick 'Only enable DisableImplicitNamespaceImports when UseWPF is set #4868' from main #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2021
Merged

Cherry-pick 'Only enable DisableImplicitNamespaceImports when UseWPF is set #4868' from main #4870

merged 1 commit into from
Jul 18, 2021

Conversation

@ryalanms
Copy link
Member

@ryalanms ryalanms commented Jul 18, 2021 •
edited
Loading

Cherry-pick "Only enable DisableImplicitNamespaceImports when UseWPF is set #4868" from main.

WinForms project also import Microsoft.WinFX.targets, and WinForms now relies on implicit imports. Scope disabling implicit imports to WPF. This broke WinForms VB projects.

But it wasn't @JunTaoLuo's change(s). It's actually caused by DisableImplicitNamespaceImports here: ff1be8e#diff-681ca681001fbc20488df7fdbb46a8c40ac2df9dc2210df5ad869aee6a56df16R23
This disables these VB imports:
https://github.com/dotnet/sdk/blob/55195f3c4ba3f582aa91ec824bd24a7ba3e73528/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.props#L118-L129

/cc @dotnet/wpf-developers

Required to unblock: dotnet/installer#11143.

@ryalanms ryalanms requested a review from a team as a code owner July 18, 2021 17:45
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 18, 2021
@ghost ghost requested review from SamBent and fabiant3 July 18, 2021 17:45
@ryalanms ryalanms merged commit 5698bf2 into release/6.0-preview7 Jul 18, 2021
@vishalmsft vishalmsft deleted the cherry.pick.implicit.namespace.imports.fix branch February 10, 2022 06:04
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@SamBent SamBent Awaiting requested review from SamBent

Assignees

No one assigned

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryalanms